Repository navigation
Conversation
4fb5403 to
ae99325
Compare
Previous review (2026-11-03)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The new Glide FS mode does what it says: the PR's new and modified autotests pass at head, and I found no blocking issues. Should fix
Minor (2)
The blank lines before Not fully reviewed: ChibiOS builds and flash cost, the full Plane/QuadPlane autotest suites, and Q_ASSIST/tiltrotor behaviour during Glide FS were not run. |
Global Size Summary (Total Flash delta in bytes)Built from dc351bb rebased onto a995235
|
|
Could it be extended to become proper glide mode? |
This change in behavior is intentional, it makes the glide failsafe action consistent with other actions such as RTL. |
|
Possibly stale comment above |
|
@IamPete1 can you look and see if you are happy with the AI review comment, I think it's deliberate, but please check |
Hwurzburg
left a comment
There was a problem hiding this comment.
Since this is true mode and can be pilot entered, the name should be GLIDE not GLIDE FS, since FS is not the only way it gets activated...
I wanted to differentiate it from soaring/thermaling, but maybe your right, certainty |
There was a problem hiding this comment.
Love this @IamPete1 , but I agree with @Hwurzburg - let's just call it "Glide", since it can be pilot entered. 4 char abbreviation could be GLID I think.
Georacer
left a comment
There was a problem hiding this comment.
I much prefer this incarnation, well done!
I am of the opinion that GLIDE_FS is a better name for the mode, because simply glide to me would mean some sort of user control.
Appending the "_FS" somewhat conveys that this mode is handicapped in some way.
Perhaps even better we could prevent the user from going into GLIDE_FS completely via RC, just like FLTMODE_GCSBLOCK does?
| Mode::run(); | ||
|
|
||
| // Always zero throttle | ||
| SRV_Channels::set_output_scaled(SRV_Channel::k_throttle, 0.0); |
There was a problem hiding this comment.
I like this. It can accommodate ICE options in the future, akin to what Henry is asking for.
|
If the name has FS in it I think it must have a block for pilot mode changes....otherwise I am against it from a confusing label point of view
|
|
#3037 is relevant |
|
I have decided that since it is a full mode there is no real reason not to let the user switch into it. It takes more code to prevent that. We certainly should not recommend people add it to there mode switch without understanding its behavior. But I can think of some cases where it may be useful to switch into it manually. |
ae99325 to
dc351bb
Compare
|
Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The dedicated Glide mode still works as described at Minor (3)
The red Not fully reviewed: the full Plane and QuadPlane autotest suites, Q_ASSIST/tiltrotor/tailsitter behaviour in Glide, ChibiOS builds other than MatekF405, and hardware were not run. |
Summary
A alternate approach to #34351, by making the glide failsafe a dedicated mode all the tricky entry and exit behavior is resolved.
Classification & Testing (check all that apply and add your own)
Description
Changes to a dedicated mode, there is some behavior changes as a result, but I think for the better. The benefit of the dedicated mode is that its clearer to the user when they are in normal FBWA and when there in a Glide failsafe. There is no contradiction of reported mode and behavior. I'm open to better name ideas, I wanted to make it clear that this was a failsafe and not related to soaring/thermaling.
This also opens the path for potential improvements, such as gliding into the wind rather than just holding 0/0.