chore: Update supported languages list#152
Open
anysoftkeyboard-bot wants to merge 1 commit into
Open
Conversation
Member
Author
🛠 **Do** — No blockers found.
🟡 **Try** — Improvements for reliability.
💡 **Consider** — Refactor or maintenance suggestions.
### 🟡 Try
* **Verify Scraper Alignment**: While reviewing the diff, I noticed some significant jumps in statistics, such as **Urdu (`ur`)** increasing its `articleCount` from ~297k to ~422k (a ~42% increase). Given the current official Wikipedia stats for Urdu (approx. 214k articles), this suggests the `update_languages.py` script might be picking up data from incorrect columns or rows (e.g., "Total Pages" or "Users" instead of "Articles") if the table structure on the Wikimedia Meta page has changed. It is recommended to verify the `parse_languages` logic against the current live HTML of [List of Wikipedias](https://meta.wikimedia.org/wiki/List_of_Wikipedias).
* **Trailing Commas in Script**: The script `scripts/update_languages.py` (lines 141-143) generates Kotlin code without a trailing comma for the last property of `SupportedLanguage`. While the auto-formatter fixes this, adding it to the template would result in cleaner script output.
```python
# scripts/update_languages.py
content += f' activeUserCount = {lang["activeUserCount"]},\n' # Add comma
```
### 💡 Consider
* **Sorting Stability
<!-- cassandra-ai-review --> |
7abdd65 to
775acd9
Compare
775acd9 to
5c5e574
Compare
5c5e574 to
f7789ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the list of supported Wikipedia languages based on the latest statistics.