-
Notifications
You must be signed in to change notification settings - Fork 579
CustomSettings Implementation #2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keval-finimble
wants to merge
21
commits into
master
Choose a base branch
from
2758-feature-customisation-json
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
fb6c06c
- Removed static concept from CustomSettings and called the class dir…
f300667
- Removed static concept from CustomSettings and called the class dir…
b6f67f9
- Refactor the code.
58f61c3
- Removed old function for getting chains from JSON file and have add…
241cb05
- Removed static concept from CustomSettings and called the class dir…
8fcca67
- Removed static concept from CustomSettings and called the class dir…
09dcb9a
- Refactor the code.
b4a9012
- Removed old function for getting chains from JSON file and have add…
954f487
- Added Unit test for CustomSettings.
ed89002
Merge remote-tracking branch 'origin/2758-feature-customisation-json'…
f1415da
- Refactor the code.
e953f58
- Removed static concept from CustomSettings and called the class dir…
21b36d0
- Removed static concept from CustomSettings and called the class dir…
1c7a210
- Refactor the code.
7a3110f
- Removed old function for getting chains from JSON file and have add…
d552a0d
- Added Unit test for CustomSettings.
a83f68d
- Removed static concept from CustomSettings and called the class dir…
011f2ea
- Removed old function for getting chains from JSON file and have add…
37e002b
- Refactor the code.
14581b9
Merge remote-tracking branch 'origin/2758-feature-customisation-json'…
41c7a3e
- Resolved conflicts.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
37 changes: 37 additions & 0 deletions
37
app/src/androidTest/java/com/alphawallet/app/CustomSettingsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.alphawallet.app; | ||
|
|
||
| import static com.alphawallet.app.assertions.Should.shouldSee; | ||
| import static com.alphawallet.app.steps.Steps.createNewWallet; | ||
| import static com.alphawallet.app.util.Helper.waitUntilLoaded; | ||
| import static org.hamcrest.Matchers.notNullValue; | ||
| import static org.junit.Assert.assertThat; | ||
|
|
||
| import com.alphawallet.app.util.Helper; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import java.io.File; | ||
| import java.net.URL; | ||
|
|
||
| public class CustomSettingsTest extends BaseE2ETest | ||
| { | ||
| private static File getFileFromPath(Object obj) { | ||
| ClassLoader classLoader = obj.getClass().getClassLoader(); | ||
| assert classLoader != null; | ||
| URL resource = classLoader.getResource("assets/custom_view_settings.json"); | ||
| return new File(resource.getPath()); | ||
| } | ||
|
|
||
| @Test | ||
| public void fileObjectShouldNotBeNull() throws Exception { | ||
|
keval-finimble marked this conversation as resolved.
Outdated
|
||
| File file = getFileFromPath(this); | ||
| assertThat(file, notNullValue()); | ||
|
|
||
| createNewWallet(); | ||
| Helper.wait(1); | ||
| shouldSee(R.id.back); | ||
| waitUntilLoaded(); | ||
| } | ||
|
|
||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "exclusive_chains": [ | ||
| { | ||
| "chain": 1 | ||
| } | ||
| ], | ||
| "locked_chains": [ | ||
| { | ||
| "chain": 1 | ||
| }, | ||
| { | ||
| "chain": 4 | ||
| }, | ||
| { | ||
| "chain": 10 | ||
| } | ||
| ], | ||
| "locked_tokens": [ | ||
| { | ||
| "tokenAddress": "0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48", | ||
| "tokenName": "USD Coin", | ||
| "tokenSymbol": "USDC", | ||
| "tokenDecimals": 6, | ||
| "isEnabled": true, | ||
| "chainId": 1 | ||
| } | ||
| ], | ||
| "dark_mode": false, | ||
| "isShowContractAddress": true, | ||
| "startupDelay": 0, | ||
| "imageOverride": 0, | ||
| "isHideDappBrowser": false, | ||
| "isHideTabBar": false, | ||
| "isHasDirectTransfer": true, | ||
| "isCanChangeWallets": true, | ||
| "isHideEIP681": false, | ||
| "isCanAddTokens": true, | ||
| "isShowManageTokens": true, | ||
| "isShowAllNetworks": false, | ||
| "getDecimalPlaces": 5 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
166 changes: 0 additions & 166 deletions
166
app/src/main/java/com/alphawallet/app/entity/CustomViewSettings.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.