Skip to content

Added JEP 356: Enhanced Pseudo-Random Number Generators demo referenc… - #282

Merged
AloisSeckar merged 9 commits into
AloisSeckar:masterfrom
sayiamarora:feature/jep356-random-generators-demo
Oct 26, 2025
Merged

Added JEP 356: Enhanced Pseudo-Random Number Generators demo referenc…#282
AloisSeckar merged 9 commits into
AloisSeckar:masterfrom
sayiamarora:feature/jep356-random-generators-demo

Conversation

@sayiamarora

@sayiamarora sayiamarora commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

This PR adds the JEP 356 demo reference (Enhanced Pseudo-Random Number Generators) to the Java17 initialization file, aligning with other JEP demo entries.

Closes #221

@AloisSeckar AloisSeckar left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sayiamarora and thank you for your contribution. I have just two little remarks to be addressed. Please, have a look.

Comment thread src/main/java/org/javademos/java17/jep356/RandomGenerators17.java Outdated
Comment thread src/main/java/org/javademos/java17/jep356/RandomGenerators17.java Outdated
@AloisSeckar AloisSeckar added the changes requested The PR was checked and feedback provided. Changes must be done in order to get it accepted. label Oct 23, 2025
@sayiamarora

Copy link
Copy Markdown
Contributor Author

Hey @AloisSeckar I have committed the changes please review them

@AloisSeckar

Copy link
Copy Markdown
Owner

Thank you, @sayiamarora

The code looks good now, but we recently added new check if the demo collection still runs after the changes and it is failing for your new demo.

The runtime exception is:

Error: Exception in thread "main" java.lang.ClassCastException: class jdk.internal.random.L64X128MixRandom cannot be cast to class java.util.random.RandomGenerator$JumpableGenerator (jdk.internal.random.L64X128MixRandom and java.util.random.RandomGenerator$JumpableGenerator are in module java.base of loader 'bootstrap')
	at org.javademos.java17.jep356.RandomGenerators17.demo(RandomGenerators17.java:33)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at org.javademos.Main.main(Main.java:65)
Error: Process completed with exit code 1.

Can you please check your implementation?

@sayiamarora

Copy link
Copy Markdown
Contributor Author

@AloisSeckar have fixed the issue can you please check!!!

@AloisSeckar

Copy link
Copy Markdown
Owner

Unfortunately, the pipeline failed again.

I am heading for a sport event now and cannot investigate. Will look in the evening.

@AloisSeckar AloisSeckar left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I have identified the problems with your PR. Please have a look.

Comment thread src/main/java/org/javademos/java17/jep356/RandomGenerators17.java Outdated
Comment thread src/main/java/org/javademos/java17/jep356/RandomGenerators17.java
@sayiamarora

Copy link
Copy Markdown
Contributor Author

@AloisSeckar used the correct jumpable generator as discussed and correct link I think this time it would work.

@AloisSeckar
AloisSeckar merged commit 585fcb1 into AloisSeckar:master Oct 26, 2025
1 check passed
@AloisSeckar AloisSeckar added hacktoberfest Counts as submission for Hacktoberfest 2025 and removed changes requested The PR was checked and feedback provided. Changes must be done in order to get it accepted. labels Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Counts as submission for Hacktoberfest 2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JEP 356 - Enhanced Pseudo-Random Number Generators

2 participants