Skip to content

prevent query error on scoped entity when filter=W10= #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
westwoodworm wants to merge 3 commits into
base: main
Choose a base branch
from
Open

prevent query error on scoped entity when filter=W10= #2

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
372d996
prevent query error on scoped entity when filter=W10=
Jan 2, 2024
6c05e13
reject non-valid filter in query builder instead of avoid such query
Jan 10, 2024
39ac12b
use variable to avoid repetition
Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Pachyderm/Orm/QueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ private function addWhere($globalOperator, $field, $operator, $value)
}

if ($field instanceof QueryBuilder) {
if (empty($field->build())) return $this;
$this->append($globalOperator, $field->build());

@mermetbt mermetbt Jan 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you build twice?

@westwoodworm westwoodworm Jan 16, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

return $this;
}
Expand Down