[OGUI-1906] Notification pauses on hover and allows copying#3513
Draft
isaachilly wants to merge 8 commits into
Draft
[OGUI-1906] Notification pauses on hover and allows copying#3513isaachilly wants to merge 8 commits into
isaachilly wants to merge 8 commits into
Conversation
Notifications now pause auto-hide while hovered, so users have time to read longer or normal message at their leisure. Added a copy-to-clipboard button inside the notification, flush with the right edge, that copies the message and displays a new "Text copied to clipboard" notification when clicked.
Adds tests for pause-on-hover and copy functionality. Adjusts queryRouter cllass test so that `window.notification` isn't being overwritten making notification class less simple to test,
Copy state now lives within the copy button through use of different icons and notification model attributes. Adjust tests to the functionality. Restructure tests to be one describe with 2 child blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Adds CSS as notification is now a more complex element.
Adds JS to override timeout hide on hover.
Adds a copy button to notification to make it more useful.