fix: critical security issues#70
Merged
Merged
Conversation
…erts Replace all assert() calls with proper runtime error handling since asserts are no-ops in release builds. Fix critical bugs: wbuf_append overflow check, DECR_BY adding instead of subtracting, config parser dangling pointers to stack locals, socket() return value check, memory leaks on error paths, and use-after-free in event loops from stale event references. Cap VLA event arrays at 1024, restrict Unix socket permissions to 0770, add SO_REUSEADDR, and bound sscanf formats. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds security improvements based on #67 audit performed.
It mainly focused on fixing buffer/memory bugs
added network security fixes:
and also hardens the event loop: