global integration - #120
Open
wangdaliu wants to merge 6 commits into
Open
Conversation
KennethNickles
approved these changes
Jul 8, 2022
KennethNickles
left a comment
KennethNickles
left a comment
There was a problem hiding this comment.
Looks good to me after comments
| Affirm.initialize(new Affirm.Configuration.Builder("public key") | ||
| .setEnvironment(Affirm.Environment.SANDBOX) | ||
| .setCountryCode("USA") // Default USA | ||
| .setLocale(Locale.US.toString()) // Default en_US |
There was a problem hiding this comment.
Same here Locale.US.toLanguageTag()
Contributor
Author
There was a problem hiding this comment.
toLanguageTag returns en-US, but what we need is en_US @KennethNickles
Contributor
|
HI @wangdaliu can we get your help answering the questions above? |
wangdaliu
force-pushed
the
internationalization
branch
from
September 16, 2022 03:05
771904b to
30e02b0
Compare
Merged
|
Why are we re-opening a PR from 2 years ago? Has it been rebased on master? PR should have full description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.