feat(terminal): bundle everything into the apk#2197
Conversation
Greptile SummaryThis PR bundles the Alpine Linux root filesystem and
Confidence Score: 4/5The non-F-Droid bundled-asset path works correctly, but the F-Droid download path assembles the wrong GitHub raw domain, causing every proot library download to fail on F-Droid builds. The URL split-string builder for the F-Droid path omits the trailing src/plugins/terminal/www/Terminal.js — the rawGithubDomain string array and the F-Droid download flow. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[install called] --> B{isFdroid === 'true'?}
B -- F-Droid --> C[Build URLs via split-string builder]
C --> D[Download alpine.tar.gz from alpinelinux.org]
D --> E[Download axs from GitHub Releases]
E --> F[Download proot libs from raw.githubusercontent.com ❌ wrong domain]
B -- non-F-Droid --> G[system.extractAsset alpine.rootfs → alpine.tar.gz]
G --> H[ln -s NATIVE_DIR/libaxs.so PREFIX/axs]
F --> I[ensureDir + tar extract]
H --> I
I --> J[startAxs --installing]
J --> K{FDROID in init-sandbox.sh?}
K -- true --> L[PROOT_LOADER from PREFIX/ libs]
K -- false --> M[PROOT_LOADER from NATIVE_DIR/ + bind -b NATIVE_DIR]
L --> N[exec proot sandbox]
M --> N
Reviews (3): Last reviewed commit: "Update Terminal.js" | Re-trigger Greptile |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
so it basically gluing Alpine only what about #2186 option 2 |
@Victozee26 Hard Luck for Playstore users, they'll have to stick to one, other distro's rootfs are larger in size, so we can't include more rootfs bundled inside for those users. |
@bajrangCoder is working a distro manager plugin that will include debian/ubuntu etc |
TODO