Repository navigation
✨ Add variable definition feature - #27
Merged
Merged
Conversation
carishkaa
force-pushed
the
feat/18-definition-provider
branch
2 times, most recently
from
February 3, 2026 09:21
72e68e5 to
ab46971
Compare
pavelsvagr
approved these changes
Feb 23, 2026
pavelsvagr
left a comment
pavelsvagr
left a comment
Member
There was a problem hiding this comment.
I like the implementation, I just have one code design question. Otherwise nice job done!
|
|
||
| const matches: KeyMatch[] = [] | ||
| // eslint-disable-next-line security/detect-non-literal-regexp | ||
| const regex = new RegExp(`"${escapeRegExp(key)}"\\s*:\\s*`, 'g') |
Member
There was a problem hiding this comment.
Question: What about using more of context and it's helpers?
I can imagine this implementation being a new Configuru Event. Methods can be new helpers. I can see here at least something like / getEnvFilesKeys returning file paths and keys in the Env file.
Collaborator
Author
There was a problem hiding this comment.
Added a new event and moved getEnvFilesKeys to helpers
carishkaa
force-pushed
the
feat/18-definition-provider
branch
from
May 4, 2026 14:50
ab46971 to
bb35f1f
Compare
carishkaa
force-pushed
the
feat/18-definition-provider
branch
from
May 4, 2026 14:54
bb35f1f to
2c1dc6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18