Repository navigation
Conversation
PetrPol
commented
Sep 24, 2026
PetrPol
commented
- Screens can now be snapshot on an unfolded foldable — the band between a phone and a tablet, where a width-driven layout is most likely to break.
- Pinned the snapshot-name contract for every device, so a future one cannot silently produce broken golden file names.
An unfolded foldable sits in a band no existing device covered: wider than Material's Expanded breakpoint (840dp) yet far narrower than a tablet in landscape, and nearly square, so both orientations land on the same side of most width breakpoints. A layout that branches on width can therefore behave differently there than on either device the library already offered. Paparazzi already ships the device, so the mapping is exact rather than hand-rolled: 2076x2152px at 390dpi, i.e. 852x883dp. The snapshot-name label is Pixel9ProFold, and a new test pins the label contract for every enum entry, so a future device cannot silently introduce an underscore into a golden file name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mottljan
approved these changes
Sep 24, 2026
|
|
||
| test("every device has a snapshot-name label that is unique and free of underscores") { | ||
| val labels = Device.entries.map { DeviceConfig(it, DeviceOrientation.PORTRAIT).name } | ||
| labels.forEach { it shouldNotContain "_" } |
Contributor
There was a problem hiding this comment.
Use forAll instead of forEach
Used forAll instead of forEach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.