Repository navigation
CI convergence (keep per-package Makefile jobs) + AquaSec - #55
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
WalkthroughThe pull request updates Dependabot grouping, adds package-specific pip updates, introduces conditional test and link-check workflows, adds a scheduled Aquasec scan, and aligns existing workflow triggers, permissions, concurrency, and action pins. ChangesCI automation
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant Detect
participant LinkCheck
participant Lychee
GitHubActions->>Detect: inspect changed Markdown files
Detect->>LinkCheck: provide docs_changed output
LinkCheck->>Lychee: check Markdown links and fragments
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… checking and security scanning
Overview
Converges
living-doc-toolkit's CI onto the canonical Phase 0 shell established inliving-doc-collector-gh(P0-A7), without flattening the per-package job strategy —each matrix leg still runs
make qa, which fans out tomake qa-<alias>per package asP0-TK-3established..github/workflows/test.yml— rebuilt with workflow-levelpermissions: { contents: read },a
concurrencygroup (cancel-in-progress), adetectjob that path-filters**/*.py/**/pyproject.toml/**/requirements*.txtviagh api(PR) /git diff(push),a
noopjob for docs-only changes, and a Python3.10 → 3.14matrix. The3.10leg iscontinue-on-erroruntilliving-doc-utilitiespublishes aRequires-Python >= 3.10release. The QA step now calls
make qa(was the deprecatedmake py-qa) and installs viamake install..github/workflows/aquasec-night-scan.yml— added, byte-identical tocollector-gh's(nightly
AbsaOSS/organizational-workflowsreusable AquaSec scan)..github/workflows/link-check.yml— added, byte-identical tocollector-gh's(
detecton**/*.md→lycheeverse/lychee-action, with anoopleg)..github/dependabot.yml— converged torepo-conventions.md§10.1 with the monorepoadaptation: one
github-actionsblock at/plus one groupedpipblock per packagedirectory (
/packages/core,/packages/datasets_pdf,/packages/adapters/collector_gh,/packages/services/normalize_issues,/packages/services/coverage_matrix,/apps/cli),each with the canonical
auto update/infrastructure/no RNlabel scheme,commit-message.prefix: "chore", anddependency-type: "direct". Previouslygithub-actions-only..github/workflows/dependabot.yml(auto-merge) — aligned tocollector-gh's reference;the
github.repository == 'AbsaOSS/living-doc-toolkit'guard is the only line that differs.This drops the temporary
# INFO: deactivated … till … Renovateguard and the commented-outname:/repository_dispatchtrigger, so the workflow is now active (as in every otherPhase 0 repo).
.github/workflows/integration.yml— addedpermissions: { contents: read }+concurrency; golden-fixture /verify_golden.py/verify_compatibility.pyjobsunchanged.
.github/workflows/release_draft.yml— re-pinnedAbsaOSS/generate-release-notesandsoftprops/action-gh-releaseto therepo-conventions.md§9.1 SHA set.Release Notes
Python QA matrix on docs-only PRs, and tests against Python 3.10–3.14; Dependabot now
tracks
pipdependencies for every package in the monorepo.Related
Closes #54
Summary by CodeRabbit