Skip to content

Fix Aquasec uses issues #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miroslavpojer merged 7 commits into from
Jan 19, 2026
Merged

Fix Aquasec uses issues #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
56aba5a
chore(workflows): update Python setup and integration test environmen…
miroslavpojer Jan 19, 2026
64458a1
Debug of int test.
miroslavpojer Jan 19, 2026
27dc9ac
chore(workflows): remove redundant env declaration for GITHUB-TOKEN i…
miroslavpojer Jan 19, 2026
297d1ee
chore(workflows): update integration tests to use consistent GITHUB_T…
miroslavpojer Jan 19, 2026
d1a0790
chore(workflows): refactor integration test steps to use environment …
miroslavpojer Jan 19, 2026
55b0ced
chore(workflows): update living-doc-collector-gh action version for d…
miroslavpojer Jan 19, 2026
6c7796c
chore(workflows): standardize GITHUB_TOKEN environment variable namin…
miroslavpojer Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/check_pr_release_notes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/setup-python@v6
- uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548
with:
python-version: '3.13'
Expand Down
50 changes: 33 additions & 17 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
env:
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}
with:
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}

Copilot AI Jan 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GITHUB-TOKEN is now duplicated in both the env block (line 33) and the with block (line 35). This duplication is unnecessary and could cause confusion. Remove the duplicate entry from the with block.

Suggested change
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}

Copilot uses AI. Check for mistakes.

@miroslavpojer miroslavpojer Jan 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 27dc9ac.

doc-issues: true
verbose-logging: true

Expand All @@ -47,11 +48,16 @@ jobs:

- name: Integration test
id: generate_living_doc_1
uses: ./
with:
source: "${{ steps.collect_data_without_project.outputs.output-path }}/doc-issues/doc-issues.json"
report-page: true
verbose-logging: true
env:
INPUT_SOURCE: "${{ steps.collect_data_without_project.outputs.output-path }}/doc-issues/doc-issues.json"
INPUT_RELEASE: "false"
INPUT_STRUCTURED_OUTPUT: "false"
INPUT_REPORT_PAGE: "true"
INPUT_VERBOSE_LOGGING: "true"
run: |
rm -rf output/generator
python main.py
echo "output-path=$PWD/output/generator/mdoc" >> "$GITHUB_OUTPUT"

- name: Show generated output
run: ls -lR "${{ steps.generate_living_doc_1.outputs.output-path }}"
Expand Down Expand Up @@ -83,6 +89,7 @@ jobs:
env:
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}
with:
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}

Copilot AI Jan 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GITHUB-TOKEN is now duplicated in both the env block (line 90) and the with block (line 92). This duplication is unnecessary and could cause confusion. Remove the duplicate entry from the with block.

Suggested change
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}

Copilot uses AI. Check for mistakes.

@miroslavpojer miroslavpojer Jan 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 27dc9ac.

doc-issues: true
verbose-logging: true

Expand All @@ -98,13 +105,17 @@ jobs:

- name: Integration test
id: generate_living_doc_1
uses: ./
env:
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}
with:
source: "${{ steps.collect_data_with_project_1.outputs.output-path }}/doc-issues/doc-issues.json"
report-page: true
verbose-logging: true
GITHUB_TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}
INPUT_SOURCE: "${{ steps.collect_data_with_project_1.outputs.output-path }}/doc-issues/doc-issues.json"
INPUT_RELEASE: "false"
INPUT_STRUCTURED_OUTPUT: "false"
INPUT_REPORT_PAGE: "true"
INPUT_VERBOSE_LOGGING: "true"
run: |
rm -rf output/generator
python main.py
echo "output-path=$PWD/output/generator/mdoc" >> "$GITHUB_OUTPUT"

- name: Show generated output
run: ls -lR "${{ steps.generate_living_doc_1.outputs.output-path }}"
Expand Down Expand Up @@ -136,6 +147,7 @@ jobs:
env:
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}
with:
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}

Copilot AI Jan 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GITHUB-TOKEN is now duplicated in both the env block (line 148) and the with block (line 150). This duplication is unnecessary and could cause confusion. Remove the duplicate entry from the with block.

Suggested change
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}

Copilot uses AI. Check for mistakes.

@miroslavpojer miroslavpojer Jan 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 27dc9ac.

doc-issues: true
verbose-logging: true

Expand All @@ -151,13 +163,17 @@ jobs:

- name: Integration test
id: generate_living_doc_2
uses: ./
env:
GITHUB-TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}
with:
source: "${{ steps.collect_data_with_project_2.outputs.output-path }}/doc-issues/doc-issues.json"
report-page: true
verbose-logging: true
GITHUB_TOKEN: ${{ secrets.REPOSITORIES_TOKEN }}
INPUT_SOURCE: "${{ steps.collect_data_with_project_2.outputs.output-path }}/doc-issues/doc-issues.json"
INPUT_RELEASE: "false"
INPUT_STRUCTURED_OUTPUT: "false"
INPUT_REPORT_PAGE: "true"
INPUT_VERBOSE_LOGGING: "true"
run: |
rm -rf output/generator
python main.py
echo "output-path=$PWD/output/generator/mdoc" >> "$GITHUB_OUTPUT"

- name: Show generated output
run: ls -lR "${{ steps.generate_living_doc_2.outputs.output-path }}"
Expand Down