Repository navigation
Conversation
…ig - it stays immutable bcause there is no point of changing author in the middle of a run (Agent is singleton)
lsulak
requested review from
ABLL526,
MatloaItumeleng,
Zejnilovic,
benedeki,
dk1844 and
salamonpavel
as code owners
August 19, 2026 10:51
|
JaCoCo Coverage Report
Run 32249303554 · Event: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable audit authorship to agents, falling back to the JVM username.
Changes:
- Resolves and trims
atum.author. - Applies the resolved author per config-backed agent.
- Adds configuration documentation and unit tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
AtumAgent.scala |
Implements configurable author resolution. |
reference.conf |
Documents atum.author. |
AtumAgentUnitTests.scala |
Tests configured, blank, and fallback authors. |
Suppressed comments (1)
agent/src/main/scala/za/co/absa/atum/agent/AtumAgent.scala:146
- This override omits the trait's
private[agent]visibility, which makesAtumAgent.currentUsera new public API on the singleton. Preserve the existing package-private contract to avoid unintentionally exposing and committing to this internal audit accessor.
override val currentUser: String = resolveAuthor(ConfigFactory.load())
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lsulak
deleted the
feature/476-making-author-of-partitioning-checkpoints-and-ad-supplieable
branch
August 19, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Related
Closes #476