Skip to content

#476: making Agent's Author supply-able from a user - #477

Merged
lsulak merged 2 commits into
masterfrom
feature/476-making-author-of-partitioning-checkpoints-and-ad-supplieable
Aug 19, 2026
Merged

lsulak merged 2 commits into
masterfrom
feature/476-making-author-of-partitioning-checkpoints-and-ad-supplieable

Conversation

@lsulak

@lsulak lsulak commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Release Notes

  • Adding a possibility to explicitly supply Author, into the Agent
  • This is possible to be loaded from Agent's config - this property stays immutable because there is no point of changing author in the middle of a run (Agent is singleton)
  • This is going to be used (when creating new entities) on Atum Partitioning and Partitioning's metadata (called Additional Data), Atum Checkpoint, and Atum Measure Definition.

Related

Closes #476

…ig - it stays immutable bcause there is no point of changing author in the middle of a run (Agent is singleton)
@github-actions

github-actions Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

JaCoCo Coverage Report

Metric (instruction) Coverage Threshold Status
Overall 65.29% 64.0% ✅
Changed Files 82.31% 80.0% ✅
Group Coverage (O/Ch) Threshold (O/Ch) Status (O/Ch)
atum-agent 79.13% / 82.31% 78.0% / 80.0% ✅/✅
Report Coverage (O/Ch) Threshold (O/Ch) Status (O/Ch)
Report: agent_spark3 - scala:2.13.13 79.13% / 82.31% 78.0% / 80.0% ✅/✅
File Path Coverage Threshold Status
AtumAgent.scala 82.31% 60.0% ✅

Run 32249303554 · Event: pull_request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds configurable audit authorship to agents, falling back to the JVM username.

Changes:

  • Resolves and trims atum.author.
  • Applies the resolved author per config-backed agent.
  • Adds configuration documentation and unit tests.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
AtumAgent.scala Implements configurable author resolution.
reference.conf Documents atum.author.
AtumAgentUnitTests.scala Tests configured, blank, and fallback authors.
Suppressed comments (1)

agent/src/main/scala/za/co/absa/atum/agent/AtumAgent.scala:146

  • This override omits the trait's private[agent] visibility, which makes AtumAgent.currentUser a new public API on the singleton. Preserve the existing package-private contract to avoid unintentionally exposing and committing to this internal audit accessor.
  override val currentUser: String = resolveAuthor(ConfigFactory.load())

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@salamonpavel salamonpavel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsulak
lsulak merged commit 5a19b6b into master Aug 19, 2026
10 checks passed
@lsulak
lsulak deleted the feature/476-making-author-of-partitioning-checkpoints-and-ad-supplieable branch August 19, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the author of partitioning and checkpoints etc suppliable

3 participants