Repository navigation
#328: making partitioning author available for Flow and Partitioning Reader - #458
Merged
Merged
Conversation
lsulak
requested review from
ABLL526,
MatloaItumeleng,
Zejnilovic,
benedeki,
dk1844 and
salamonpavel
as code owners
July 23, 2026 11:00
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Reader module API to expose the author of the partitioning that identifies a FlowReader or PartitioningReader, using the existing /api/v2/partitionings?partitioning=... lookup and adding unit tests to validate the new behavior.
Changes:
- Added
getAuthortoFlowReaderandPartitioningReaderto return the partitioning author. - Refactored
PartitioningIdProviderto query a fullPartitioningWithIdDTOonce and derive bothpartitioningIdandpartitioningAuthorfrom it. - Added unit tests covering the new author retrieval paths.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| reader/src/main/scala/za/co/absa/atum/reader/core/PartitioningIdProvider.scala | Refactors partitioning lookup into partitioningWithId and adds partitioningAuthor. |
| reader/src/main/scala/za/co/absa/atum/reader/FlowReader.scala | Adds getAuthor to expose the main flow partitioning author. |
| reader/src/main/scala/za/co/absa/atum/reader/PartitioningReader.scala | Adds getAuthor to expose the reader partitioning author. |
| reader/src/test/scala/za/co/absa/atum/reader/FlowReaderUnitTests.scala | Adds unit test ensuring flow partitioning author is queried and returned. |
| reader/src/test/scala/za/co/absa/atum/reader/PartitioningReaderUnitTests.scala | Adds unit test ensuring partitioning author is queried and returned. |
| reader/src/test/scala/za/co/absa/atum/reader/core/PartitioningIdProviderUnitTests.scala | Adds unit test for partitioningAuthor helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
JaCoCo Coverage Report
Run 30001468169 · Event: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces new functionality to retrieve the author of a partitioning in the Atum Reader module. It adds
getAuthormethods to bothFlowReaderandPartitioningReader, refactors the way partitioning information is queried, and includes corresponding unit tests to ensure the new functionality works as expected.Release Notes
getAuthormethod toFlowReaderandPartitioningReader, allowing retrieval of the author associated with a partitioning (FlowReader.scala,PartitioningReader.scala).Related
Closes #328