Skip to content

#328: making partitioning author available for Flow and Partitioning Reader - #458

Merged
lsulak merged 1 commit into
masterfrom
feature/328-partitioning-author-surfacing
Jul 23, 2026
Merged

lsulak merged 1 commit into
masterfrom
feature/328-partitioning-author-surfacing

Conversation

@lsulak

@lsulak lsulak commented Jul 23, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

This PR introduces new functionality to retrieve the author of a partitioning in the Atum Reader module. It adds getAuthor methods to both FlowReader and PartitioningReader, refactors the way partitioning information is queried, and includes corresponding unit tests to ensure the new functionality works as expected.

Release Notes

  • Added getAuthor method to FlowReader and PartitioningReader, allowing retrieval of the author associated with a partitioning (FlowReader.scala, PartitioningReader.scala).

Related

Closes #328

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Reader module API to expose the author of the partitioning that identifies a FlowReader or PartitioningReader, using the existing /api/v2/partitionings?partitioning=... lookup and adding unit tests to validate the new behavior.

Changes:

  • Added getAuthor to FlowReader and PartitioningReader to return the partitioning author.
  • Refactored PartitioningIdProvider to query a full PartitioningWithIdDTO once and derive both partitioningId and partitioningAuthor from it.
  • Added unit tests covering the new author retrieval paths.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
reader/src/main/scala/za/co/absa/atum/reader/core/PartitioningIdProvider.scala Refactors partitioning lookup into partitioningWithId and adds partitioningAuthor.
reader/src/main/scala/za/co/absa/atum/reader/FlowReader.scala Adds getAuthor to expose the main flow partitioning author.
reader/src/main/scala/za/co/absa/atum/reader/PartitioningReader.scala Adds getAuthor to expose the reader partitioning author.
reader/src/test/scala/za/co/absa/atum/reader/FlowReaderUnitTests.scala Adds unit test ensuring flow partitioning author is queried and returned.
reader/src/test/scala/za/co/absa/atum/reader/PartitioningReaderUnitTests.scala Adds unit test ensuring partitioning author is queried and returned.
reader/src/test/scala/za/co/absa/atum/reader/core/PartitioningIdProviderUnitTests.scala Adds unit test for partitioningAuthor helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lsulak lsulak changed the title #328: making partitioning author available for flor and partitioning reader #328: making partitioning author available for Flow and Partitioning Reader Jul 23, 2026
@github-actions

Copy link
Copy Markdown

JaCoCo Coverage Report

Metric (instruction) Coverage Threshold Status
Overall 65.09% 64.0% ✅
Changed Files 94.08% 80.0% ✅
Group Coverage (O/Ch) Threshold (O/Ch) Status (O/Ch)
atum-reader 79.85% / 94.08% 74.0% / 80.0% ✅/✅
Report Coverage (O/Ch) Threshold (O/Ch) Status (O/Ch)
Report: reader - scala:2.13.13 79.85% / 94.08% 74.0% / 80.0% ✅/✅
File Path Coverage Threshold Status
FlowReader.scala 93.33% 60.0% ✅
PartitioningIdProvider.scala 100.0% 60.0% ✅
PartitioningReader.scala 93.31% 60.0% ✅

Run 30001468169 · Event: pull_request

@lsulak
lsulak merged commit 751f883 into master Jul 23, 2026
12 of 13 checks passed
@lsulak
lsulak deleted the feature/328-partitioning-author-surfacing branch July 23, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Author of the Partitioning available in FlowReader and PartitioningReader

2 participants