Issue #340: Add benchmark env smoke test to CI#343
Open
Sammy-Dabbas wants to merge 1 commit into
Open
Conversation
Adds a run-benchmarks CI job that builds one representative environment from each benchmark module (nadir_science, aeos_single, rso_inspection) and steps it a few times, so PRs that break benchmark env construction fail fast without running full PPO training.
9cb65f7 to
9b92df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #340.
What this does
Adds a
run-benchmarksjob tocommit_checks.ymlplus a smallbenchmarks/smoke_test.pydriver. The job builds via the existing.github/actions/buildaction (Python 3.11,pip-options: all,rllib, mirroringcheck-doc-build) and then constructs one representative environment from each benchmark module --nadir_science,aeos_single, andrso_inspection-- and steps each 3 times.Design choices
benchmark.py --total_timesteps 0still spins up Ray and builds a full PPO model, so the smoke script bypasses Ray/RLlib entirely and exercises only environment construction and the PettingZoo step loop. Breakages in benchmark env definitions fail in minutes instead of requiring a training run.env_argscarries the RLlib-onlyepisode_data_callback/satellite_data_callbackkeys thatConstellationTasking.__init__does not accept; the script strips them the same way_constellation_tasking_env_creatordoes.working-directory: benchmarksbecause the benchmark modules use top-level imports (from benchmark import BenchmarkEnv).Verification
Basilisk is a heavy native build, so locally I validated the workflow YAML, ruff/isort cleanliness, and traced every invocation against the actual signatures (
ConstellationTaskingkwargs, PettingZoo agent-keyedstepdicts). The end-to-end run happens in this PR's own CI via the new job. Happy to adjust scope (e.g. more envs per module or a different Python version) if you'd prefer.