Add natural_indices to the shared evaluation interface#10
Merged
Conversation
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
natural_indicesfunction stub alongside the existingevaluate*stubs, so it can serve as a shared ACEsuit interface function (returning a
basis's "natural" descriptions, e.g.
(l, m)for spherical harmonics, instorage order).
This is the enabling change for decoupling SpheriCart from Polynomials4ML:
ACEbaseExtdefinesnatural_indicesfor its harmonics(Complex harmonics + ACEbase evaluate-interface extension lab-cosmo/sphericart#235).
natural_indicestoimport ACEbase: natural_indices(Decouple SpheriCart from Polynomials4ML Polynomials4ML.jl#123).No behaviour change for existing code; patch bump 0.4.6 → 0.4.7.
Should be registered first, as #235 and #123 require it.
🤖 Generated with Claude Code