Skip to content

Fix quad and n-gon OBJ/faces - Fan-triangulate #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dirlligafu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix quad and n-gon OBJ/faces - Fan-triangulate #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion model_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,14 @@ def _parse_obj_groups(path):
uv_ambiguous += 1
else:
vertex_uv[v_idx] = vt_idx
groups[current].append(idx)
if len(idx) < 3:
continue
# Fan-triangulate quads/n-gons: exported OBJs without a
# "Triangulate" step mix face vertex counts, which crashes
# np.array(all_faces) downstream with an inhomogeneous-shape
# error since it expects every face to have the same length.
for i in range(1, len(idx) - 1):
groups[current].append([idx[0], idx[i], idx[i + 1]])

if not groups.get("(ungrouped)"):
groups.pop("(ungrouped)", None)
Expand Down