Skip to content

fix: Send credentials callback to match normal message send callbacks #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silverbucket merged 3 commits into from
Mar 29, 2026
Merged

fix: Send credentials callback to match normal message send callbacks #304

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bbe451
check result object for errors
silverbucket Mar 1, 2026
bac9448
Update app/services/sockethub-irc.js
silverbucket Mar 29, 2026
76393c2
Update app/services/sockethub-irc.js
silverbucket Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/services/sockethub-irc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@ export default class SockethubIrcService extends Service {

this.log('irc', 'connecting to IRC network...');

this.sockethubClient.socket.emit('credentials', credentialsJob, (err) => {
if (err) { this.log('failed to store credentials: ', err); }
this.sockethubClient.socket.emit('credentials', credentialsJob, (msg) => {
const error = (msg && typeof msg === 'object') ? msg.error : msg;
if (error) { this.log('failed to store credentials: ', error); }
});

this.sockethubClient.socket.emit('message', connectJob, (message) => {
Expand Down
Loading