Skip to content

Add kokkosparallel docker and workflow - #2162

Merged
PhilipOesterlePekrun merged 2 commits into
4C-multiphysics:mainfrom
PhilipOesterlePekrun:docker-update-2012-create-kokkosparallel-docker
Aug 6, 2026
Merged

Add kokkosparallel docker and workflow#2162
PhilipOesterlePekrun merged 2 commits into
4C-multiphysics:mainfrom
PhilipOesterlePekrun:docker-update-2012-create-kokkosparallel-docker

Conversation

@PhilipOesterlePekrun

@PhilipOesterlePekrun PhilipOesterlePekrun commented Aug 6, 2026

Copy link
Copy Markdown
Member

This PR is related to and should precede #2012. @ppraegla suggested that the docker and related workflow are pushed in a separate PR first (see #2012 (comment)). Therefore, this PR just adds the new Trilinos installation scripts, dependencies hash computation, dockerfile, and docker_kokkosparallel.yml workflow file.

Signed-off-by: Philip Oesterle-Pekrun <philipoesterlepekrun@gmail.com>
Signed-off-by: Philip Oesterle-Pekrun <philipoesterlepekrun@gmail.com>

@mayrmt mayrmt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the GitHub workflows, but installation scripts look fine.

@PhilipOesterlePekrun

Copy link
Copy Markdown
Member Author

@mayrmt The workflow is basically a copy of the standard docker workflow with some small changes. So, it will allow us to use the workflow/action to build and push the docker, as Patrick suggested.

@ppraegla ppraegla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the PR.

@ppraegla

ppraegla commented Aug 6, 2026

Copy link
Copy Markdown
Member

As a note: Once this PR is merged, the tag-images-as-main job in the workflow will fail on main because the image does not yet exist. And you can only build the image once the workflow is on main. This means there will be no main tag until the docker image is update once more. But for me, it's okay not to have the main tag until the next real update of the docker image.

@PhilipOesterlePekrun
PhilipOesterlePekrun merged commit aa8389c into 4C-multiphysics:main Aug 6, 2026
44 checks passed
@ppraegla

ppraegla commented Aug 6, 2026

Copy link
Copy Markdown
Member

After checking the workflow file again, you can just trigger the manual build again once the docker build is finished. The workflow checks if the image already exists, which is it does. So, the build is not run again. But the docker image is tagged as main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants