Modify dual shape function construction to work for curved beams - #2124
Draft
dharinib98 wants to merge 1 commit into
Draft
Modify dual shape function construction to work for curved beams#2124dharinib98 wants to merge 1 commit into
dharinib98 wants to merge 1 commit into
Conversation
Comment on lines
+301
to
+308
| Core::LinAlg::Matrix<1, Beam::n_nodes_ * Beam::n_val_, double> N_mortar_primal( | ||
| Core::LinAlg::Initialization::zero); | ||
| Core::LinAlg::Matrix<Mortar::n_dof_, Mortar::n_dof_, double> local_D_mortar( | ||
| Core::LinAlg::Initialization::zero); | ||
| Core::LinAlg::Matrix<Mortar::n_dof_, Mortar::n_dof_, double> local_M_mortar( | ||
| Core::LinAlg::Initialization::zero); | ||
| Core::LinAlg::Matrix<Mortar::n_dof_, Mortar::n_dof_, double> local_A( | ||
| Core::LinAlg::Initialization::zero); |
Contributor
There was a problem hiding this comment.
I am not a big fan of adding these matrices here for all cases, even tough they war only needed for one special case.
| N_beam, projected_gauss_point.get_eta(), this->ele1pos_.shape_function_data_); | ||
| N_beam, eta, this->ele1pos_.shape_function_data_); | ||
|
|
||
| if constexpr (std::is_same_v<Mortar, BeamInteraction::HermiteDual>) |
Contributor
There was a problem hiding this comment.
With this proposed change, do we even need the explicit implementation of the dual shape functions any more?
| for (unsigned int i_row = 0; i_row < LambdaType::n_dof_; i_row++) | ||
| for (unsigned int i_col = 0; i_col < BeamType::n_dof_; i_col++) | ||
| EXPECT_NEAR(local_D(i_row, i_col), result_local_D(i_row, i_col), 1e-11); | ||
| EXPECT_NEAR(local_D(i_row, i_col), result_local_D(i_row, i_col), 1e-11; |
Contributor
There was a problem hiding this comment.
Is this a syntax error?
| result_local_D(11, 2) = 0.000000000003244959856374408; | ||
| result_local_D(11, 5) = -0.0000000000001378064329315976; | ||
| result_local_D(11, 8) = -0.00000000001687716633114178; | ||
| result_local_D(11, 11) = 0.2121320343565152; |
Contributor
There was a problem hiding this comment.
Why do we need to adapt the test results?
|
|
||
| // compute local_A matrix | ||
| const unsigned int n_segments = this->line_to_3D_segments_.size(); | ||
| if constexpr (std::is_same_v<Mortar, BeamInteraction::HermiteDual>) |
Contributor
There was a problem hiding this comment.
We have to talk about this general procedure. This proposed solution should work fine, but I think will fail if the beam spans over multiple solid elements. We have to at least investigate what happens in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
In this PR, the currently implemented dual LM construction have been modified according to the equations (3.64 - 3.65) from Popp, A.: Mortar methods for computational contact mechanics and general interface
problems. Dissertation, Technische Universität München (2012)
Related Issues and Pull Requests
#2009