forked from node-inspector/node-inspector
-
Notifications
You must be signed in to change notification settings - Fork 1
Contributing
Miroslav Bajtoš edited this page Aug 1, 2013
·
2 revisions
The only "official" Node Inspector repository is https://github.com/node-inspector/node-inspector. For code, docs, tests, or anything else, node-inspector/node-inspector is the repository where all patches have to end up if they are going to be in the release. To submit a patch fork the repository and send a pull request via github to node-inspector/node-inspector.
- Miguel de Icaza has a good post on Open Source Contribution Etiquette that is worth reading, as the guidance he gives applies well to Node Inspector.
- Create a github issue for large changes and discuss the change there before coding
- Javascript code style should follow Google's JavaScript style guide and be run through the linter.
npm run lintto validate, you need to have GJsLint installed.
Node Inspector comes with an automated test suite run via "npm test". The tests are written in BDD style using mocha and chai.
- the first line should be maximum 50 columns
- the second line should be blank
- any additional lines should not exceed 72 columns.
- should have the author field properly filled out with your full name and email address.
To generate patch files:
- Clone the git repository.
- Create a branch for you change/feature off of the master branch.
- Make your change. Remember to update tests as well as code!
- Commit your change and push it to github.
- Use github's pull requests to submit the patch.