01a0d378 - Count an About-me photo as welcome media - #53
Merged
TaprootFreak merged 3 commits intoSep 24, 2026
Merged
TaprootFreak merged 3 commits into
TaprootFreak merged 3 commits into
Conversation
welcomeHasMedia from the api includes the profile note. When that field is absent, the previous hasPosted and hasMedia check still applies.
Welcome is not a no_post skip. no_media follows welcomeHasMedia when the api sends that boolean.
A 403 Forum post required on the welcome bucket is skipped as no_media and is not stored as failed.
Collaborator
Author
|
EN: DE: DetailsPass 1 aligned the readme with the welcome skip. Pass 2 stopped treating a welcome invoice refusal as a missing living-room post; that refusal is missing media and is not stored, so a later ping can retry. Pass 3 found no defects. Checks on 75bb65f: test and e2e succeeded. The pull request is mergeable. There are no review threads. |
TaprootFreakAI
marked this pull request as ready for review
September 24, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
The welcome gift counts an About-me photo when the api sends
welcomeHasMedia.If that field is missing, the previous living-room
hasPostedandhasMediacheck still applies.The daily gift is unchanged.
A welcome invoice answered with Forum post required is skipped as no media and can be retried.
DE:
Das Willkommensgeschenk zählt ein Über-mich-Foto, wenn die API
welcomeHasMediaschickt.Fehlt das Feld, gilt weiter die bisherige Wohnzimmer-Prüfung
hasPostedundhasMedia.Das tägliche Geschenk bleibt unverändert.
Antwortet die Willkommens-Rechnung mit Forum post required, wird das als fehlendes Medium übersprungen und kann erneut versucht werden.
Details
hasPostednow returnswelcomeHasMedia(nullwhen the field is absent or not a boolean) andwelcomeMessageId.The welcome bucket pays when
welcomeHasMediais true, even ifhasPostedis false because the only photo is the profile note. The invoice useswelcomeMessageIdunless the ping already named a message.welcomeHasMedia: falseskips asno_mediaeven if the daily media flag is true.Invoice-create 403
Forum post requiredisno_mediafor welcome and is not stored as a failed payout, so a later ping can retry. Daily and moderator keepno_postfor that same 403.