Skip to content

01a0d378 - Count an About-me photo as welcome media - #53

Merged
TaprootFreak merged 3 commits into
21gifts:developfrom
TaprootFreakAI:feat/01a0d378-welcome-about-photo
Sep 24, 2026
Merged

TaprootFreak merged 3 commits into
21gifts:developfrom
TaprootFreakAI:feat/01a0d378-welcome-about-photo

Conversation

@TaprootFreakAI

@TaprootFreakAI TaprootFreakAI commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

EN:
The welcome gift counts an About-me photo when the api sends welcomeHasMedia.
If that field is missing, the previous living-room hasPosted and hasMedia check still applies.
The daily gift is unchanged.
A welcome invoice answered with Forum post required is skipped as no media and can be retried.

DE:
Das Willkommensgeschenk zählt ein Über-mich-Foto, wenn die API welcomeHasMedia schickt.
Fehlt das Feld, gilt weiter die bisherige Wohnzimmer-Prüfung hasPosted und hasMedia.
Das tägliche Geschenk bleibt unverändert.
Antwortet die Willkommens-Rechnung mit Forum post required, wird das als fehlendes Medium übersprungen und kann erneut versucht werden.

Details

hasPosted now returns welcomeHasMedia (null when the field is absent or not a boolean) and welcomeMessageId.

The welcome bucket pays when welcomeHasMedia is true, even if hasPosted is false because the only photo is the profile note. The invoice uses welcomeMessageId unless the ping already named a message. welcomeHasMedia: false skips as no_media even if the daily media flag is true.

Invoice-create 403 Forum post required is no_media for welcome and is not stored as a failed payout, so a later ping can retry. Daily and moderator keep no_post for that same 403.

welcomeHasMedia from the api includes the profile note. When that field
is absent, the previous hasPosted and hasMedia check still applies.
Welcome is not a no_post skip. no_media follows welcomeHasMedia when
the api sends that boolean.
A 403 Forum post required on the welcome bucket is skipped as no_media and is not stored as failed.
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 3 review passes.
The welcome gift counts an About-me photo, and a welcome invoice refused for a missing forum post is skipped so a later ping can retry.

DE:
Bereit nach 3 Review-Durchläufen.
Das Willkommensgeschenk zählt ein Über-mich-Foto, und eine Willkommens-Rechnung ohne Forenbeitrag wird übersprungen, damit ein späterer Versuch sie erneut zahlen kann.

Details

Pass 1 aligned the readme with the welcome skip. Pass 2 stopped treating a welcome invoice refusal as a missing living-room post; that refusal is missing media and is not stored, so a later ping can retry. Pass 3 found no defects.

Checks on 75bb65f: test and e2e succeeded. The pull request is mergeable. There are no review threads.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 24, 2026 15:15
@TaprootFreak
TaprootFreak merged commit 782c0a1 into 21gifts:develop Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants