01a0ac32 - Let owners attach a JPEG, PNG, or WebP on About me - #258
Merged
Merged
Conversation
TaprootFreakAI
force-pushed
the
01a0ac32-about-me-photos
branch
3 times, most recently
from
September 17, 2026 18:38
2ade9b7 to
9c30bea
Compare
TaprootFreakAI
marked this pull request as ready for review
September 17, 2026 18:47
Reuse the forum photo pipeline on the profile note: omit keeps the stored image, null clears it, and an object sets it. Owner, public view, and member cards load the bytes through same-origin GET proxies.
Save and attach stay disabled until prepareForumPhoto finishes. A newer pick, cancel, or unmount drops a stale prepare result so the JPEG is not silently omitted.
Remove bumps the prepare generation so an in-flight JPEG cannot come back after the owner clears it. Saving a new or cleared photo also invalidates an older GET so the stored preview cannot flash back.
Handbook and visual variants cover a photo-only About me card on profile and public view. A hanging loadPhoto that finishes after save-remove no longer restores the old JPEG.
IconButton catalog strings Add a photo and Remove photo must not appear as visible text, matching the in-card attach rule.
Leaving the blob URL in state kept the card filled after the parent dropped aboutMeHasPhoto. The load effect now revokes and nulls it.
The editor states now include the image-plus control next to the text field. Baselines come from the Linux Chromium actuals of the CI visual jobs.
Rebase onto develop brought new typed Account literals without the field. Typecheck requires it on every constructed Account.
TaprootFreakAI
force-pushed
the
01a0ac32-about-me-photos
branch
from
September 17, 2026 18:53
66e4d71 to
e2490ec
Compare
Develop brought a typed Account literal without the field. Typecheck requires it on every constructed Account.
TaprootFreakAI
marked this pull request as draft
September 17, 2026 18:54
TaprootFreakAI
marked this pull request as ready for review
September 17, 2026 18:59
TaprootFreakAI
marked this pull request as draft
September 17, 2026 19:03
The about-photo variants now seed a bio plus a stored JPEG so owner profile and public view match a filled About me with both.
Collaborator
Author
|
EN: DE: DetailsReview completed with 0 findings at 5b6f3a5. The about-photo visual variants now show bio text and photo together on owner profile and public view. |
TaprootFreakAI
marked this pull request as ready for review
September 17, 2026 19:12
TaprootFreak
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Owners can attach one JPEG, PNG, or WebP on About me the same way as a forum post.
Omit keeps the stored photo, null clears it, and an object replaces it.
Public view and member cards show the image when the profile note has one.
Same-origin GET proxies serve the bytes; this is not a kind:0 avatar.
DE:
Im Über-mich kann man ein JPEG, PNG oder WebP anhängen, analog zu einem Foren-Post.
Weglassen behält das gespeicherte Foto, null löscht es, ein Objekt ersetzt es.
Öffentliche View- und Member-Karten zeigen das Bild, wenn die Profilnotiz eines hat.
Same-Origin-GET-Proxies liefern die Bytes; das ist kein kind:0-Avatar.
Details
PUT /me/about
{ text, photo? }tri-state. GET /me/about/photo (Bearer) and GET /view-key/[viewKey]/about/photo (public). Account JSON includesaboutMeHasPhoto.prepareForumPhotoprepares the payload. No video. No POST /me/profile.