Skip to content

01a0adcb - Show inbox unread in the menu and home-screen badge - #255

Merged
TaprootFreak merged 12 commits into
developfrom
feat/01a0adcb-inbox-unread
Sep 18, 2026
Merged

TaprootFreak merged 12 commits into
developfrom
feat/01a0adcb-inbox-unread

Conversation

@TaprootFreakAI

@TaprootFreakAI TaprootFreakAI commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

EN:
The signed-in Menu now shows an unread count on Messages, the same way Notifications already does.
Opening a thread marks it read; unread rows in the inbox list use a stronger name and last-text.
The home-screen PWA badge is notifications unread plus inbox unread; visiting /notifications does not clear remaining inbox from the icon.

DE:
Das eingeloggte Menü zeigt beim Posteingang eine Ungelesen-Zahl, analog zu Benachrichtigungen.
Ein geöffneter Thread gilt als gelesen; ungelesene Zeilen in der Liste haben einen kräftigeren Namen und Last-Text.
Das Home-Screen-Badge ist Benachrichtigungen plus ungelesener Posteingang; /notifications wischt den restlichen Posteingang nicht vom Icon.

Details
  • Menu: nav.inboxUnread plus a right-side count when inbox unread is greater than zero
  • GET /conversations unread flags drive the count; missing API fields default to false/0
  • Opening /messages?c= POSTs /conversations/:id/read and clears that row locally
  • Home-screen badge: useUnreadCount waits for both fetches, then writes the sum
  • NotificationsLoader no longer forces badge 0; remaining inbox unread stays
  • After opening a thread, the badge refreshes to the remaining sum
  • Incoming DM Web Push already opens /messages?c=<id> in the service worker

Needs the matching api change for live unread data and conversation push payloads.

@TaprootFreakAI
TaprootFreakAI force-pushed the feat/01a0adcb-inbox-unread branch from 7e6de9d to 2d37eee Compare September 17, 2026 17:28
@TaprootFreakAI TaprootFreakAI changed the title 01a0adcb - Show inbox unread count in the menu 01a0adcb - Show inbox unread in the menu and home-screen badge Sep 17, 2026
@TaprootFreakAI
TaprootFreakAI force-pushed the feat/01a0adcb-inbox-unread branch from 2d37eee to 71ef0d4 Compare September 17, 2026 19:58
Load conversation unread beside notifications, mark a thread read when it
opens, and style unread inbox rows.
The badge is notifications plus inbox unread. Visiting /notifications
does not clear remaining inbox unread from the icon.
Bump the badge epoch on logout, exclude the open thread from remaining
inbox unread, and add SCREEN_VARIANTS for inbox-unread menu and list.
openConversation now returns Conversation with unread after the
inbox-unread schema; the #240 thread fixture must set it.
Linux Chromium drifted 15 pixels on the mobile combos after the
about-me photo screen landed on develop.
clearAuth bumps the badge epoch before zeroing. refreshUnreadAppBadge
and the notifications inbox write skip a mismatched session. The e2e
needle counts a notifications GET after the thread opens.
The qemu-linux refresh drifted 15 pixels from GitHub-hosted Chromium.
…base.

Conversation rows keep lastSats and unread. Same-origin proxies keep
POST invoice and POST read. Inbox list styling keeps unread inbound
rows and gift-only last-sats previews.
@TaprootFreakAI
TaprootFreakAI force-pushed the feat/01a0adcb-inbox-unread branch from 3c1587d to d78d65e Compare September 17, 2026 21:42
Opening a thread clears unread and refreshes the badge locally first.
The mock conversations list now returns lastSats and unread together.
Unread inbound names are semibold with foreground last-text; read inbound
last-text stays muted; outbound last-text stays the sent chip.
setUnreadAppBadge is not called from InboxLoader. unreadAppBadgeEpoch
is also used by NotificationsLoader and refreshUnreadAppBadge. The
conversations/[id] tree lists invoice then read.
The badge refresh after inbox mark-read reads the session token and
GET /forum/notifications; handbook Used-by now names those callers.
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 4 review passes.
The signed-in menu shows an unread count on Messages like Notifications, and the home-screen badge is notifications plus listed inbox unread.

DE:
Bereit nach 4 Review-Durchläufen.
Das eingeloggte Menü zeigt beim Posteingang eine Ungelesen-Zahl wie bei Benachrichtigungen, und das Home-Screen-Badge ist Benachrichtigungen plus ungelesener Posteingang.

Details

Head cc52f689. Four review passes on this develop stand: keep-both wreckage after the pay-sheet rebase, fire-and-forget mark-read, inbox list grammar, then handbook Used-by. Last pass 0 findings. Comment gate: no open review threads, no inline comments, no CHANGES_REQUESTED. Mergeable: MERGEABLE. CI: Typecheck/Lint/Handbook/E2E-check/Screenshots/Test/Build, E2E (behavior), and four visual jobs success on this head.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 17, 2026 23:13
@TaprootFreak
TaprootFreak merged commit 9d71dfd into develop Sep 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants