01a0abb0 - Let members choose All, Active, or Mentions notifications - #233
Merged
Merged
Conversation
TaprootFreakAI
force-pushed
the
01a0abb0-notification-level
branch
5 times, most recently
from
September 17, 2026 17:19
7a4c7b0 to
a97f843
Compare
TaprootFreakAI
marked this pull request as ready for review
September 17, 2026 17:56
TaprootFreakAI
marked this pull request as draft
September 17, 2026 19:55
TaprootFreakAI
force-pushed
the
01a0abb0-notification-level
branch
from
September 17, 2026 20:03
a97f843 to
e7ece5c
Compare
TaprootFreakAI
marked this pull request as ready for review
September 17, 2026 20:39
TaprootFreakAI
marked this pull request as draft
September 17, 2026 20:48
Let signed-in members pick a fan-out level next to the push bell and persist it via POST /me/notification-level.
A successful POST /me/notification-level now updates only that field and ignores the response after logout, matching the other profile forms. Handbook and CONTRIBUTING mention the three-stage control.
POST /me/notification-level on the e2e stub is 401 without a bearer. PushToggle tests cover a missing store account and a response without notificationLevel. Linux Chromium goldens match the three-stage control on the full-page profile states that include Notifications.
The Function: postNotificationLevel spec now signs in, clicks Active, and waits for POST /me/notification-level 200 so the client export runs through Next, not only the visible All/Active/Mentions labels.
Full-page /profile states now include All/Active/Mentions and the shared one-row settings pills from develop.
Failed POST /me/notification-level now uses role=alert and danger copy, with handbook, SCREEN_VARIANTS, and four Linux Chromium goldens.
TaprootFreakAI
force-pushed
the
01a0abb0-notification-level
branch
from
September 17, 2026 20:51
e7ece5c to
9a950e3
Compare
TaprootFreakAI
marked this pull request as ready for review
September 17, 2026 20:55
TaprootFreak
approved these changes
Sep 17, 2026
TaprootFreakAI
marked this pull request as draft
September 17, 2026 21:01
Collaborator
Author
|
EN: DE: DetailsHead Previous four-lane review at Visual (mobile-dark) flaked 15 pixels on |
TaprootFreakAI
marked this pull request as ready for review
September 17, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
The signed-in Profile Notifications section now has All / Active / Mentions next to the push bell.
Changing the control POSTs
/me/notification-leveland updates the account. The control stays visible even when Web Push is unavailable.Pairs with the api PR that stores and applies the level.
DE:
Auf dem angemeldeten Profil gibt es unter Benachrichtigungen Alle / Aktiv / Erwähnungen neben der Glocke.
Ein Wechsel speichert per POST
/me/notification-level. Die Stufe bleibt sichtbar, auch ohne Web Push.Gehört zum API-PR, der die Stufe speichert und beim Fan-out anwendet.
Details
Default when GET /me omits the field is All. Failure keeps the previous value and shows an error. Catalogs: en, de, es, fil.