Skip to content

Unpin activesupport to address version constraint mismatch downstream#164

Merged
Sgtpluck merged 2 commits into
mainfrom
dmm/relax_activesupport_pinning
Jun 23, 2026
Merged

Unpin activesupport to address version constraint mismatch downstream#164
Sgtpluck merged 2 commits into
mainfrom
dmm/relax_activesupport_pinning

Conversation

@Sgtpluck

Copy link
Copy Markdown

Updating the identity-idp to use the last tagged version failed with:

And because actionview >= 8.1.3 depends on activesupport = 8.1.3
  and actionview < 8.1.0 depends on activesupport = 8.0.5,
  activesupport = 8.0.5 OR = 8.1.0 OR = 8.1.1 OR = 8.1.2 OR = 8.1.2.1 OR = 8.1.3 is required.
So, because every version of saml_idp depends on activesupport ~> 7.2.3
  and Gemfile depends on saml_idp >= 0,
  version solving has failed.

this change removes the active pinning in the gemspec to resolve the constraint mismatch.

Comment thread saml_idp.gemspec

s.required_ruby_version = '>= 3.3.4'

s.add_dependency('activesupport', '~> 7.2.3')

@h-m-m h-m-m Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would setting this to >= 7.2.3 also solve the conflict?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, can do that instead.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in ab9e0ea

@ajfarkas ajfarkas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance of this biting us later?

@Sgtpluck

Copy link
Copy Markdown
Author

@ajfarkas no, not really, since we control the gem and the consumer. it's technically an open source gem but at this point it's bespoke enough for our purposes that no one else is using it.

@Sgtpluck Sgtpluck merged commit b43d9e2 into main Jun 23, 2026
5 checks passed
@Sgtpluck Sgtpluck deleted the dmm/relax_activesupport_pinning branch June 23, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants