Unpin activesupport to address version constraint mismatch downstream#164
Merged
Conversation
h-m-m
reviewed
Jun 23, 2026
|
|
||
| s.required_ruby_version = '>= 3.3.4' | ||
|
|
||
| s.add_dependency('activesupport', '~> 7.2.3') |
There was a problem hiding this comment.
Would setting this to >= 7.2.3 also solve the conflict?
ajfarkas
approved these changes
Jun 23, 2026
ajfarkas
left a comment
There was a problem hiding this comment.
Is there a chance of this biting us later?
Author
|
@ajfarkas no, not really, since we control the gem and the consumer. it's technically an open source gem but at this point it's bespoke enough for our purposes that no one else is using it. |
h-m-m
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the identity-idp to use the last tagged version failed with:
this change removes the active pinning in the gemspec to resolve the constraint mismatch.