Fix macOS fixed-mode ghost-frame from stale back-buffer content - #1148
Merged
aHooder merged 3 commits intoJul 29, 2026
Merged
Conversation
The scene blit only covers the scene viewport, and drawUi() preserves destination RGB wherever the UI texture is transparent. On macOS, rlawt recycles IOSurface back buffers without clearing them, so stale frame content could show through regions neither pass covers, e.g. the margins around the 3D viewport in fixed display mode. Clear the default framebuffer at the top of the composite path so every region starts from black. Fixes 117HD#1124. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Could you try if this PR fixes this #1123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS in fixed display mode, stale back-buffer content leaks into screen regions outside the 3D scene viewport (full diagnosis in #1124). The scene blit only covers
sceneViewport, anddrawUi()preserves destination RGB wherever the UI texture is transparent — so any region neither pass covers shows whatever was left in the back buffer. On macOS, rlawt's IOSurface pool recycles back buffers without clearing them, which is how a several-frames-old frame can reappear in the fixed-mode margins.This hoists the clear that previously only ran on the no-scene path to the top of the composite path in
ZoneRenderer.draw(), so the default framebuffer always starts from black before the scene blit and UI draw.Verified via A/B toggling on a dev client on macOS (bundled rlawt unchanged): with the clear, the ghost frame no longer appears when toggling 117HD or Stretched Mode in fixed mode.
Fixes #1124
🤖 Generated with Claude Code