Add optional client-side limit to FetchNotesRequest - #84
Draft
Dominik1999 wants to merge 2 commits into
Draft
Conversation
- Add `optional uint32 limit` field to FetchNotesRequest proto - Server clamps client limit to FETCH_NOTES_BATCH_SIZE (500) - When unset, server default (500) applies - Thread limit parameter through Database trait, facade, and SQLite impl - Regenerate proto bindings Closes #46 Closes #4 Supersedes #56 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Treat limit=0 as None (use server default) instead of returning empty - Record notes_returned in the tracing span Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mmagician
reviewed
Jun 8, 2026
mmagician
left a comment
mmagician
left a comment
Collaborator
There was a problem hiding this comment.
Left a comment in the client-counterpart issue: 0xMiden/rust-sdk#2107
3 tasks
Dominik1999
marked this pull request as draft
June 17, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optional uint32 limitfield toFetchNotesRequestprotolimit: 10for a mobile wallet)FETCH_NOTES_BATCH_SIZE(500) - client can tighten, never exceedlimit=0treated as unset (uses server default)Supersedes the original #56 with a rewrite on current main, incorporating the seq-cursor migration, multi-tag snapshot queries, and structured tracing.
Client-side follow-up: 0xMiden/miden-client#2107
Test plan
make lintpassesmake testpasses (13/13)limit: Some(N)to verify clamping behavior🤖 Generated with Claude Code
Closes #46
Closes #4