refactor: remove SQLite in-memory database support - #113
Open
kkovaacs wants to merge 3 commits into
Open
Conversation
kkovaacs
marked this pull request as ready for review
August 6, 2026 15:50
Mirko-von-Leipzig
approved these changes
Aug 6, 2026
Comment on lines
+96
to
+101
| if is_in_memory_url(&config.url) { | ||
| return Err(DatabaseError::Configuration( | ||
| "SQLite in-memory databases are not supported; provide a database file path" | ||
| .to_string(), | ||
| )); | ||
| } |
There was a problem hiding this comment.
I'm not sure I would have gone so far :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in issue #112 defaulting to an in-memory database poses risks for anyone running the service.
This PR fixes that risk by:
--database-urlCLI option required, so that you cannot start the service without specifying where it should store its data.Closes #112