Skip to content

Commit c3d5767

Browse files
committed
RFC: simplify AnalysisCallback implementation
1 parent 9362472 commit c3d5767

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

yt_astro_analysis/halo_analysis/halo_catalog/analysis_operators.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,10 @@ class AnalysisCallback:
2121
to the target object, write out data, etc, but does not return anything.
2222
"""
2323

24-
def __init__(self, function, args=None, kwargs=None):
24+
def __init__(self, function, *args, **kwargs):
2525
self.function = function
2626
self.args = args
27-
if self.args is None:
28-
self.args = []
2927
self.kwargs = kwargs
30-
if self.kwargs is None:
31-
self.kwargs = {}
3228

3329
def __call__(self, target):
3430
self.function(target, *self.args, **self.kwargs)
@@ -49,9 +45,6 @@ class AnalysisFilter(AnalysisCallback):
4945
whether analysis is continued.
5046
"""
5147

52-
def __init__(self, function, *args, **kwargs):
53-
AnalysisCallback.__init__(self, function, args, kwargs)
54-
5548
def __call__(self, target):
5649
return self.function(target, *self.args, **self.kwargs)
5750

@@ -69,9 +62,6 @@ class AnalysisQuantity(AnalysisCallback):
6962
performs some analysis, and then returns a value.
7063
"""
7164

72-
def __init__(self, function, *args, **kwargs):
73-
AnalysisCallback.__init__(self, function, args, kwargs)
74-
7565
def __call__(self, target):
7666
return self.function(target, *self.args, **self.kwargs)
7767

0 commit comments

Comments
 (0)