Skip to content

Commit 1f91223

Browse files
committed
CA-417645 Refine Remote Shell status in xsconsole
Signed-off-by: Lunfan Zhang[Lunfan.Zhang] <Lunfan.Zhang@cloud.com>
1 parent 972cd0b commit 1f91223

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

XSConsoleData.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,7 @@ def update_SR_reference(inPool, retPool, key):
366366
self.UpdateFromKeymap()
367367

368368
self.data['chkconfig'] = {}
369+
self.data['service_active'] = {}
369370
self.ScanService('sshd')
370371
self.ScanService('chronyd')
371372

@@ -768,6 +769,9 @@ def ScanService(self, service):
768769
(status, output) = getstatusoutput("systemctl is-enabled %s" % (service,))
769770
self.data['chkconfig'][service] = status == 0
770771

772+
(status, output) = getstatusoutput("systemctl is-active %s" % (service,))
773+
self.data['service_active'][service] = status == 0
774+
771775
def ScanResolvConf(self, inLines):
772776
self.data['dns'] = {
773777
'nameservers' : [],

plugins-base/XSFeatureRemoteShell.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def HandleChoice(self, inChoice):
6868
"Command Shell to terminate them.")
6969
if inChoice == self.SSH_MODE_AUTO:
7070
data.SetSSHAutoMode(True)
71-
message = Lang("SSH auto-mode has been configured. For security,"
71+
message = Lang("SSH auto-mode has been configured. For security, "
7272
"SSH is normally disabled and will only be enabled in case of emergency.")
7373

7474
Layout.Inst().PushDialogue(InfoDialogue(message))
@@ -139,16 +139,18 @@ def StatusUpdateHandler(cls, inPane):
139139
data = Data.Inst()
140140
inPane.AddTitleField(Lang("Remote Shell (ssh)"))
141141

142-
if data.chkconfig.sshd() is None:
143-
message = Lang('unknown. To enable or disable')
144-
elif data.chkconfig.sshd():
145-
message = Lang('enabled. To disable')
142+
is_running = data.service_active.sshd()
143+
144+
if is_running is None:
145+
message = Lang('unknown. To configure')
146+
elif is_running:
147+
message = Lang('running. To stop and disable')
146148
else:
147-
message = Lang('disabled. To enable')
149+
message = Lang('stopped. To start and enable')
148150

149151
inPane.AddWrappedTextField(Lang(
150-
"This server can accept a remote login via ssh. Currently remote login is ") +
151-
message + Lang(" this feature, press <Enter>."))
152+
"This server can accept a remote login via ssh. Currently SSH service is ") +
153+
message + Lang(" SSH service, press <Enter>."))
152154

153155
inPane.AddKeyHelpField( {
154156
Lang("<Enter>") : Lang("Configure Remote Shell")

0 commit comments

Comments
 (0)