Merge pull request #287 from JacobBarthelmeh/testing

ejohnstown · web-flow · commit 3647697d4664 · 2021-02-01T16:41:45.000-08:00
close local file on error case
diff --git a/src/wolfsftp.c b/src/wolfsftp.c
@@ -7815,7 +7815,7 @@ int wolfSSH_SFTP_Get(WOLFSSH* ssh, char* from,
                         }
                         WLOG(WS_LOG_SFTP, "Error reading packet");
                         ret = WS_FATAL_ERROR;
-                        state->state = STATE_GET_CLEANUP;
+                        state->state = STATE_GET_CLOSE_LOCAL;
                         break;
                     }
                     else {
@@ -8017,7 +8017,7 @@ int wolfSSH_SFTP_Put(WOLFSSH* ssh, char* from, char* to, byte resume,
                         return WS_FATAL_ERROR;
                     }
                     WLOG(WS_LOG_SFTP, "Error getting handle");
-                    state->state = STATE_PUT_CLEANUP;
+                    state->state = STATE_PUT_CLOSE_LOCAL;
                     continue;
                 }
                 state->state = STATE_PUT_WRITE;

Original file line number	Diff line number	Diff line change
`@@ -7815,7 +7815,7 @@ int wolfSSH_SFTP_Get(WOLFSSH* ssh, char* from,`
`7815`	`7815`	`}`
`7816`	`7816`	`WLOG(WS_LOG_SFTP, "Error reading packet");`
`7817`	`7817`	`ret = WS_FATAL_ERROR;`
`7818`		`- state->state = STATE_GET_CLEANUP;`
	`7818`	`+ state->state = STATE_GET_CLOSE_LOCAL;`
`7819`	`7819`	`break;`
`7820`	`7820`	`}`
`7821`	`7821`	`else {`
`@@ -8017,7 +8017,7 @@ int wolfSSH_SFTP_Put(WOLFSSH* ssh, char* from, char* to, byte resume,`
`8017`	`8017`	`return WS_FATAL_ERROR;`
`8018`	`8018`	`}`
`8019`	`8019`	`WLOG(WS_LOG_SFTP, "Error getting handle");`
`8020`		`- state->state = STATE_PUT_CLEANUP;`
	`8020`	`+ state->state = STATE_PUT_CLOSE_LOCAL;`
`8021`	`8021`	`continue;`
`8022`	`8022`	`}`
`8023`	`8023`	`state->state = STATE_PUT_WRITE;`