diff --git a/internal/controller/reconciler/reconcile_v2.go b/internal/controller/reconciler/reconcile_v2.go index 38234bac..f54ba889 100644 --- a/internal/controller/reconciler/reconcile_v2.go +++ b/internal/controller/reconciler/reconcile_v2.go @@ -53,14 +53,17 @@ var defaultRequeueMinutes = 1 var defaultRequeueDuration = time.Duration(defaultRequeueMinutes) * time.Minute var managedWorkloadTelemetryApplications = map[string]struct{}{ - "api": {}, - "executor": {}, - "filemeta": {}, - "filestream": {}, - "flat-run-fields-updater": {}, - "glue": {}, - "metric-observer": {}, - "parquet": {}, + "api": {}, + "executor": {}, + "filemeta": {}, + "filestream": {}, + "flat-run-fields-updater": {}, + "glue": {}, + "metric-observer": {}, + "parquet": {}, + "weave-trace": {}, + "weave-trace-evaluate-model-worker": {}, + "weave-trace-worker": {}, } var managedWorkloadStatsdApplications = map[string]struct{}{ diff --git a/internal/controller/reconciler/telemetry_test.go b/internal/controller/reconciler/telemetry_test.go index 6ffb602b..b1a80748 100644 --- a/internal/controller/reconciler/telemetry_test.go +++ b/internal/controller/reconciler/telemetry_test.go @@ -4,6 +4,7 @@ import ( "context" "testing" + "github.com/stretchr/testify/assert" apiv2 "github.com/wandb/operator/api/v2" serverManifest "github.com/wandb/operator/pkg/wandb/manifest" appsv1 "k8s.io/api/apps/v1" @@ -1249,7 +1250,7 @@ func TestInjectManagedWorkloadTelemetryEnvvarsAddsDatadogAgentForDdtraceApps(t * client := fake.NewClientBuilder().WithScheme(scheme).Build() wandb := telemetryStatusWandb("wandb-dev-v2", "default", "status-otel-secret") - for _, appName := range []string{"anaconda2", "weave-trace"} { + for _, appName := range []string{"anaconda2"} { t.Run(appName, func(t *testing.T) { envVars, err := injectManagedWorkloadTelemetryEnvvars( context.Background(), @@ -1290,6 +1291,17 @@ func TestInjectManagedWorkloadTelemetryEnvvarsAddsDatadogAgentForDdtraceApps(t * } } +func TestManagedWorkloadTelemetryApplicationsContainsWeaveTraceApps(t *testing.T) { + for _, name := range []string{ + "weave-trace", + "weave-trace-worker", + "weave-trace-evaluate-model-worker", + } { + _, ok := managedWorkloadTelemetryApplications[name] + assert.True(t, ok, "%q should be in the OTel allowlist", name) + } +} + func readyTelemetryResource(gvk schema.GroupVersionKind, name, namespace string) *unstructured.Unstructured { return newTelemetryResource(gvk, name, namespace, []map[string]any{{"type": "Available", "status": "True"}}) }