From a5545e2493044043b8bf91700c5090d2fa6d0f54 Mon Sep 17 00:00:00 2001 From: Maccabee Levine Date: Fri, 16 Jan 2026 13:50:17 +0000 Subject: [PATCH 1/2] Add default for ShardPreferences->showCheckboxes --- module/VuFind/src/VuFind/Search/Solr/Options.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/VuFind/src/VuFind/Search/Solr/Options.php b/module/VuFind/src/VuFind/Search/Solr/Options.php index 6edeef437d8..93c570c0165 100644 --- a/module/VuFind/src/VuFind/Search/Solr/Options.php +++ b/module/VuFind/src/VuFind/Search/Solr/Options.php @@ -155,7 +155,7 @@ public function __construct(ConfigManagerInterface $configManager) $this->defaultSelectedShards = array_keys($this->shards); } // Apply checkbox visibility setting if applicable: - if (null !== ($visibleCheckboxes = $this->searchSettings['ShardPreferences']['showCheckboxes'])) { + if (null !== ($visibleCheckboxes = $this->searchSettings['ShardPreferences']['showCheckboxes'] ?? false)) { $this->visibleShardCheckboxes = $visibleCheckboxes; } } From c21d52327449653404200e2c6e677f9c0bea99a5 Mon Sep 17 00:00:00 2001 From: Maccabee Levine <31278545+maccabeelevine@users.noreply.github.com> Date: Tue, 20 Jan 2026 09:43:57 -0500 Subject: [PATCH 2/2] Default to null Co-authored-by: Demian Katz --- module/VuFind/src/VuFind/Search/Solr/Options.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/VuFind/src/VuFind/Search/Solr/Options.php b/module/VuFind/src/VuFind/Search/Solr/Options.php index 93c570c0165..dd3422ce64c 100644 --- a/module/VuFind/src/VuFind/Search/Solr/Options.php +++ b/module/VuFind/src/VuFind/Search/Solr/Options.php @@ -155,7 +155,7 @@ public function __construct(ConfigManagerInterface $configManager) $this->defaultSelectedShards = array_keys($this->shards); } // Apply checkbox visibility setting if applicable: - if (null !== ($visibleCheckboxes = $this->searchSettings['ShardPreferences']['showCheckboxes'] ?? false)) { + if (null !== ($visibleCheckboxes = $this->searchSettings['ShardPreferences']['showCheckboxes'] ?? null)) { $this->visibleShardCheckboxes = $visibleCheckboxes; } }