feat: no ErrNoRows when scan nil struct ptr and nil map and nil builtin type ptr#1379
Open
CyJaySong wants to merge 3 commits into
Open
feat: no ErrNoRows when scan nil struct ptr and nil map and nil builtin type ptr#1379CyJaySong wants to merge 3 commits into
CyJaySong wants to merge 3 commits into
Conversation
Contributor
Author
|
@Aoang Hi Bro,look here |
bevzzz
reviewed
May 13, 2026
bevzzz
requested changes
May 13, 2026
1df5a46 to
c7b489d
Compare
c7b489d to
9e80321
Compare
bevzzz
reviewed
May 15, 2026
bevzzz
reviewed
May 20, 2026
a02c4b2 to
385b0a6
Compare
Contributor
Author
Collaborator
|
@CyJaySong I'll take another pass at the PR tomorrow, just to make sure I understand the changes well. Thanks for your patience and the effort you're putting in contributing to Bun. |
Contributor
Author
|
@bevzzz Thanks for your recognition. I‘m looking forward to a smooth merger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous writing styles
new feature
Compatible with previous writing styles