Miscs Minor Issues

[hesingh]

Thanks for developing this code an open-sourcing it.

1. Could you please add a CONTRIBUTING.md file to the repo so that folks know if you allow a Apache 2.0 license to the code. An example for CONTRIBUTING.md is given below.

https://github.com/hesingh/p4-ipv6-switch-ml/blob/master/CONTRIBUTING.md

Note, p4c uses a Apache 2.0 license.

2. Could you please add a README.md file to show to to run code in several directories.

Several folks have asked the P4 community about how to add a new extern to simple_switch and also asked for crypto extern. Seeing this repo we are adding your extern to the behavioral-model repo. Please see this PR: p4lang/behavioral-model#834

See this note from the Issue for what could help in README.md for help.

"I don't think it is necessary to give a working example that uses Mininet .
Instructions for running a single simple_switch or simple_switch_grpc process, with all command line options needed to use the new extern, should be enough. Let those who wish to use the new extern in a Mininet network figure out the changes to their own software outside of simple_switch."

Thanks.

[jafingerhut]

I think it is more accurate to say not "we are adding", but "with your permission, we would like to add".

[hesingh]

I have Scapy installed on the machine, but when I run controller.py Python causes a ImportError on scapy. Any idea what's wrong?

hemantietf@instance-1:~/p4-macsec/controller_distributed$ which scapy
/usr/local/bin/scapy
hemantietf@instance-1:~/p4-macsec/controller_distributed$ 

hemantietf@instance-1:~/p4-macsec/controller_distributed$ sudo ./controller.py -a 127.0.0.1:50051 -n s1 -s ipc:///tmp/bmv2-0-notifications.ipc -m 00:00:00:FF:01:01
Traceback (most recent call last):
  File "./controller.py", line 30, in <module>
    import cli
  File "/home/hemantietf/p4-macsec/controller_distributed/cli.py", line 26, in <module>
    from scapy.all import Packet, Ether
ImportError: No module named scapy.all
hemantietf@instance-1:~/p4-macsec/controller_distributed$ 

My os.sys.path is shown below. The machine has a $USER/.local directory.

['/home/hemantietf/p4-macsec/controller_distributed', '/usr/local/lib/python2.7/dist-packages/thrift-0.9.2-py2.7-linux-x86_64.egg', '/usr/local/lib/python2.7/dist-packages/mininet-2.3.0d6-py2.7.egg', '/usr/lib/python2.7/dist-packages', '/usr/lib/python2.7', '/usr/lib/python2.7/plat-x86_64-linux-gnu', '/usr/lib/python2.7/lib-tk', '/usr/lib/python2.7/lib-old', '/usr/lib/python2.7/lib-dynload', '/home/hemantietf/.local/lib/python2.7/site-packages', '/usr/local/lib/python2.7/dist-packages']

[jafingerhut]

If you are on an Ubuntu 16.04 or 18.04 Linux machine using Python2, you probably need to do pip install scapy. If you are using Python3, pip3 install scapy.

scapy has a command line executable, which you can find via which scapy, but that executable is a different file than the ones needed for import scapy.all to work from a Python program.

[hesingh]

I am using Ubuntu 16.04 because the macsec asked for this Ubuntu version to use. I have both Python 2 and Python 3 installed on the machine.

[marcohae]

The controller is using python2. Doing pip install scapy should be enough to get it working. Can you check if there is a folder /usr/local/lib/python2.7/dist-packages/scapy/ that contains a file all.py?

[hesingh]

Python3 is messing me up since I had to install it to fix pip on the machine.

hemantietf@instance-1:~/p4-macsec/p4/p4$ pip install scapy
Requirement already satisfied: scapy in /usr/local/lib/python3.5/dist-packages (2.4.3)
hemantietf@instance-1:~/p4-macsec/p4/p4$   

[marcohae]

In that case you can try sudo pip2 install scapy .

[jafingerhut]

If nothing you do uses Python3, there should never be a reason to install Python3 in order to use pip. My open source P4 tool scripts never used or installed anything related to Python3 until recently when p4c switched to using Python3, and they worked fine.

I am referring to a freshly installed Ubuntu 16.04 or 18.04 Linux system here. I have no idea if that is what you are starting with.

[hesingh]

I purged Python 3.5 from the machine. I have to look into pip and pip2 installs first before I can use either to install scapy.

[jafingerhut]

No matter what sequence of steps you find and document for adding an extern to behavioral-model, I plan to test that sequence of steps on a freshly installed Ubuntu Linux 16.04 machine, to ensure that it works. So you have that "safety net", if you consider it that.

[hesingh]

Actually, I had pip cause Traceback. So I looked up the issue and python3 and python were used to get rid of this error. This is why I had installed Python3.

Sure, once I have the software working, I will document the steps.

Right now, I am dealing with a problem with pip. This is why I want to uninstall pip and install it again. I have tried several uninstalls but they all failed to remove pip. I have removed Python 3.5 but some vestige remains.

hemantietf@instance-1:/usr/local/bin$ pip install scapy
-bash: /usr/local/bin/pip: /usr/bin/python3: bad interpreter: No such file or directory
hemantietf@instance-1:/usr/local/bin$

[hesingh]

Please add to the README.md that mininet also needed to be installed.

[marcohae]

Mininet is installed by the p4/vm/user-bootstrap.sh script

[jafingerhut]

@hesingh You may have better fortunes if you try starting over with a freshly installed Ubuntu Linux 16.04 machine, rather than trying to repair the state of the VM you have. I know that can be a pain, but is the nature of the beast.