Skip to content

Commit f3d88cd

Browse files
committed
Fix byte-compiler issues in gerrit-transient.el
1 parent 3175999 commit f3d88cd

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

misc/gerrit-transient.el

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
;;; gerrit-transient.el --- Gerrit transient example -*- lexical-binding: t; -*-
2+
13
;; The transient history is saved when the kill-emacs-hook is run, which is
24
;; run when (kill-emacs) is called. Make sure that you run kill-emacs when
35
;; you stop emacs (or restart an emacs (systemd) service). Note that
@@ -44,7 +46,7 @@
4446
ARGUMENT and VALUE are the values of the respective slots of OBJ.
4547
If VALUE is nil, then return nil. VALUE may be the empty string,
4648
which is not the same as nil."
47-
(when-let ((value (oref obj value)))
49+
(when-let* ((value (oref obj value)))
4850
(if (listp value) (setq value (string-join value ",")))
4951
(concat (oref obj argument) value)))
5052

@@ -58,7 +60,7 @@ which is not the same as nil."
5860
:reader 'gerrit-upload:--read-reviewers)
5961

6062
(defun gerrit-upload:--read-reviewers (prompt _initial-input history)
61-
(gerrit--init-accounts)
63+
(gerrit-get-accounts-alist)
6264
(let ((val
6365
(completing-read-multiple
6466
prompt
@@ -88,7 +90,7 @@ which is not the same as nil."
8890
:reader 'gerrit-upload:--read-topic)
8991

9092
(defun gerrit-upload:--read-assignee (prompt _initial-input history)
91-
(gerrit--init-accounts)
93+
(gerrit-get-accounts-alist)
9294
;; (gerrit--read-assignee) this doesn't update the history
9395

9496
;; using the history here doesn't have an effect (maybe it doesn, but for
@@ -115,4 +117,4 @@ which is not the same as nil."
115117
nil nil nil
116118
history))
117119

118-
(gerrit-upload-transient)
120+
(call-interactively gerrit-upload-transient)

0 commit comments

Comments
 (0)