From a1869c56af4e87a6e5b6da978c8c5a2336c5cd28 Mon Sep 17 00:00:00 2001 From: Sean Lynch <42618346+swlynch99@users.noreply.github.com> Date: Tue, 11 Oct 2022 16:24:28 -0700 Subject: [PATCH 1/2] Change errors in segcache main to print using eprintln Error messages should really go to stderr instead of stdout. --- src/server/segcache/src/main.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/server/segcache/src/main.rs b/src/server/segcache/src/main.rs index 1d37dd846..3a1a829d1 100644 --- a/src/server/segcache/src/main.rs +++ b/src/server/segcache/src/main.rs @@ -29,7 +29,7 @@ fn main() { // custom panic hook to terminate whole process after unwinding std::panic::set_hook(Box::new(|s| { error!("{}", s); - println!("{:?}", Backtrace::new()); + eprintln!("{:?}", Backtrace::new()); std::process::exit(101); })); @@ -103,7 +103,7 @@ fn main() { match SegcacheConfig::load(file) { Ok(c) => c, Err(e) => { - println!("{}", e); + eprintln!("unable to load config file: {}", e); std::process::exit(1); } } @@ -120,7 +120,7 @@ fn main() { match Segcache::new(config) { Ok(segcache) => segcache.wait(), Err(e) => { - println!("error launching segcache: {}", e); + eprintln!("error launching segcache: {}", e); std::process::exit(1); } } From 6d833f6f875323b8d83c8e23e9448078dc283d45 Mon Sep 17 00:00:00 2001 From: Sean Lynch <42618346+swlynch99@users.noreply.github.com> Date: Tue, 11 Oct 2022 16:25:39 -0700 Subject: [PATCH 2/2] Change errors in pingserver main to use stderr --- src/server/pingserver/src/main.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/server/pingserver/src/main.rs b/src/server/pingserver/src/main.rs index 285e07129..3fa6579d8 100644 --- a/src/server/pingserver/src/main.rs +++ b/src/server/pingserver/src/main.rs @@ -25,7 +25,7 @@ fn main() { // custom panic hook to terminate whole process after unwinding std::panic::set_hook(Box::new(|s| { error!("{}", s); - println!("{:?}", Backtrace::new()); + eprintln!("{:?}", Backtrace::new()); std::process::exit(101); })); @@ -96,7 +96,7 @@ fn main() { match PingserverConfig::load(file) { Ok(c) => c, Err(e) => { - println!("error launching pingserver: {}", e); + eprintln!("error loading config file: {}", e); std::process::exit(1); } } @@ -108,7 +108,7 @@ fn main() { match Pingserver::new(config) { Ok(s) => s.wait(), Err(e) => { - println!("error launching pingserver: {}", e); + eprintln!("error launching pingserver: {}", e); std::process::exit(1); } }