Repository navigation
Commit afc26b0
feat: run vnc-title on 5900/5901 and report the disclosed desktop name
vnc-info and realvnc-auth-bypass already ran on the VNC ports; vnc-title
completes the set by retrieving the desktop name once either of those paths
gets it logged in (security type None, or the RealVNC bypass — vnc-brute is
not run, so a name means no credentials were supplied). That yields the
identity of the exposed desktop, which the CRITICAL/HIGH findings do not
carry, as a LOW "VNC Desktop Name Disclosed" finding.
Two supporting changes:
- --source-port is now omitted on 5900/5901 during a script pass, via a new
_MULTI_SCRIPT_PORTS set that generalises the SMB-only special case. Three
portrule scripts each open their own RFB connection; with a fixed source
port they collide on one (src, dst) 4-tuple and all but one fail silently,
which for vnc-title looks like "no desktop name" rather than an error.
- findings.txt renders per-host detail for this title. The grouped renderer
collapsed every non-"Service Exposed Externally" finding to one shared
description, which would have dropped the desktop name — the entire point
of the finding — from the text report. _PER_HOST_DETAIL_TITLES replaces the
hardcoded title comparison. The multi-line NSE table is whitespace-collapsed
so it stays on a single line.
Failure output is filtered: every vnc-title failure path returns
stdnse.format_output(false, ...), rendering as "ERROR: ...".
907 tests pass, 100% coverage.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>1 parent 3b28357 commit afc26b0
3 files changed
Lines changed: 130 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
319 | 319 | | |
320 | 320 | | |
321 | 321 | | |
322 | | - | |
| 322 | + | |
323 | 323 | | |
324 | | - | |
| 324 | + | |
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
| |||
382 | 382 | | |
383 | 383 | | |
384 | 384 | | |
| 385 | + | |
385 | 386 | | |
386 | 387 | | |
387 | 388 | | |
| |||
412 | 413 | | |
413 | 414 | | |
414 | 415 | | |
415 | | - | |
| 416 | + | |
416 | 417 | | |
417 | 418 | | |
418 | 419 | | |
| |||
441 | 442 | | |
442 | 443 | | |
443 | 444 | | |
444 | | - | |
| 445 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1943 | 1943 | | |
1944 | 1944 | | |
1945 | 1945 | | |
1946 | | - | |
| 1946 | + | |
1947 | 1947 | | |
1948 | 1948 | | |
1949 | 1949 | | |
| |||
1974 | 1974 | | |
1975 | 1975 | | |
1976 | 1976 | | |
1977 | | - | |
1978 | | - | |
| 1977 | + | |
| 1978 | + | |
| 1979 | + | |
1979 | 1980 | | |
1980 | 1981 | | |
1981 | 1982 | | |
| |||
2458 | 2459 | | |
2459 | 2460 | | |
2460 | 2461 | | |
2461 | | - | |
2462 | | - | |
| 2462 | + | |
| 2463 | + | |
2463 | 2464 | | |
2464 | 2465 | | |
2465 | 2466 | | |
| |||
2512 | 2513 | | |
2513 | 2514 | | |
2514 | 2515 | | |
2515 | | - | |
2516 | | - | |
| 2516 | + | |
| 2517 | + | |
2517 | 2518 | | |
2518 | 2519 | | |
2519 | 2520 | | |
| |||
2528 | 2529 | | |
2529 | 2530 | | |
2530 | 2531 | | |
2531 | | - | |
2532 | | - | |
2533 | 2532 | | |
2534 | 2533 | | |
| 2534 | + | |
| 2535 | + | |
| 2536 | + | |
| 2537 | + | |
| 2538 | + | |
| 2539 | + | |
| 2540 | + | |
| 2541 | + | |
| 2542 | + | |
2535 | 2543 | | |
2536 | 2544 | | |
2537 | 2545 | | |
| |||
3505 | 3513 | | |
3506 | 3514 | | |
3507 | 3515 | | |
| 3516 | + | |
| 3517 | + | |
| 3518 | + | |
| 3519 | + | |
| 3520 | + | |
| 3521 | + | |
| 3522 | + | |
| 3523 | + | |
| 3524 | + | |
| 3525 | + | |
| 3526 | + | |
| 3527 | + | |
| 3528 | + | |
| 3529 | + | |
| 3530 | + | |
| 3531 | + | |
| 3532 | + | |
3508 | 3533 | | |
3509 | 3534 | | |
3510 | 3535 | | |
| |||
4240 | 4265 | | |
4241 | 4266 | | |
4242 | 4267 | | |
| 4268 | + | |
| 4269 | + | |
| 4270 | + | |
| 4271 | + | |
| 4272 | + | |
| 4273 | + | |
| 4274 | + | |
| 4275 | + | |
4243 | 4276 | | |
4244 | 4277 | | |
4245 | 4278 | | |
| |||
4277 | 4310 | | |
4278 | 4311 | | |
4279 | 4312 | | |
4280 | | - | |
4281 | | - | |
4282 | | - | |
| 4313 | + | |
| 4314 | + | |
| 4315 | + | |
| 4316 | + | |
4283 | 4317 | | |
4284 | 4318 | | |
4285 | 4319 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7472 | 7472 | | |
7473 | 7473 | | |
7474 | 7474 | | |
7475 | | - | |
| 7475 | + | |
7476 | 7476 | | |
7477 | 7477 | | |
7478 | 7478 | | |
| |||
7532 | 7532 | | |
7533 | 7533 | | |
7534 | 7534 | | |
| 7535 | + | |
| 7536 | + | |
| 7537 | + | |
| 7538 | + | |
| 7539 | + | |
| 7540 | + | |
| 7541 | + | |
| 7542 | + | |
| 7543 | + | |
| 7544 | + | |
| 7545 | + | |
| 7546 | + | |
| 7547 | + | |
| 7548 | + | |
| 7549 | + | |
| 7550 | + | |
| 7551 | + | |
| 7552 | + | |
| 7553 | + | |
| 7554 | + | |
| 7555 | + | |
| 7556 | + | |
| 7557 | + | |
| 7558 | + | |
| 7559 | + | |
| 7560 | + | |
| 7561 | + | |
| 7562 | + | |
| 7563 | + | |
| 7564 | + | |
| 7565 | + | |
| 7566 | + | |
| 7567 | + | |
| 7568 | + | |
| 7569 | + | |
| 7570 | + | |
| 7571 | + | |
| 7572 | + | |
| 7573 | + | |
| 7574 | + | |
| 7575 | + | |
| 7576 | + | |
| 7577 | + | |
| 7578 | + | |
| 7579 | + | |
| 7580 | + | |
| 7581 | + | |
| 7582 | + | |
| 7583 | + | |
| 7584 | + | |
| 7585 | + | |
| 7586 | + | |
| 7587 | + | |
| 7588 | + | |
| 7589 | + | |
| 7590 | + | |
| 7591 | + | |
| 7592 | + | |
| 7593 | + | |
| 7594 | + | |
| 7595 | + | |
| 7596 | + | |
| 7597 | + | |
| 7598 | + | |
| 7599 | + | |
| 7600 | + | |
| 7601 | + | |
| 7602 | + | |
| 7603 | + | |
| 7604 | + | |
| 7605 | + | |
| 7606 | + | |
| 7607 | + | |
| 7608 | + | |
| 7609 | + | |
| 7610 | + | |
| 7611 | + | |
| 7612 | + | |
7535 | 7613 | | |
7536 | 7614 | | |
7537 | 7615 | | |
| |||
0 commit comments