XMRig: Add MSR instructions, conditionally enable volumes, fix namings#5133
Open
Keeqler wants to merge 2 commits into
Open
XMRig: Add MSR instructions, conditionally enable volumes, fix namings#5133Keeqler wants to merge 2 commits into
Keeqler wants to merge 2 commits into
Conversation
stavros-k
reviewed
Jun 8, 2026
| - variable: local_xmrig_port | ||
| label: XMRig Port | ||
| description: The port your XMRig app is listening on. | ||
| - variable: local_p2pool_port |
Contributor
There was a problem hiding this comment.
Changing the schema shape (ie variable name) will make upgrades fail due to invalid set of keys.
Contributor
Author
There was a problem hiding this comment.
Maybe I can keep both and make the incorrectly named one always hidden? Lmk if this is allowed.
stavros-k
reviewed
Jun 8, 2026
| Enabling this may increase the hashrate by 10-30%, but will grant XMRig privileged | ||
| access to the host. | ||
| access to the host.</br> | ||
| IMPORTANT: For this to work, you need to load the MSR kernel module on the host every |
Contributor
There was a problem hiding this comment.
The rule is to not push users to modify host. So if tho it's the case it needs to be removed. If user wants this enabled it either does so via custom app or env or some other form of customisation
Contributor
Author
There was a problem hiding this comment.
Okay, should I just remove the message telling the user to enable MSR? Or do you want me to drop the entire feature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.