feat(community): update romm questions#5115
Conversation
| type: string | ||
| default: "" | ||
| private: true | ||
| - variable: oidc_enabled |
There was a problem hiding this comment.
OIDC most of the times require slightly different setup for each provider which will be an ever growing setup screen, I'd suggest removing this.
There was a problem hiding this comment.
The OIDC variables presented are fairly uniform across all OIDC providers. While there may be additional values for things like a "preferred username" or custom claims, those extended configurations have been left to "additional environment variables" specifically because we should only be prompting for commonly used environment variables.
There was a problem hiding this comment.
I feel that someone configuring OIDC will probably want to setup those custom things like preferred username etc and having them split up would be more confusing.
ie most "guides" list the envs you need to add, having them as fields will "force" user to go and see what each thing sets.
Making it more "annoying" that just copy pasting the guide.
| label: ScreenScraper Password | ||
| description: Password for ScreenScraper.fr | ||
| schema: | ||
| type: string |
There was a problem hiding this comment.
this shouldnt be visible if the user field is empty
There was a problem hiding this comment.
is pw required when username is provided? If thats the case, we should require it. (required:true)
2 participants
App Enhancement
AI
Description
Updates RomM in the community train.
[Brief description of what the app does]
Testing
Tested locally with:
All tests passed successfully.
Special Notes
Checklist