Skip to content

Commit fb2b3e0

Browse files
committed
Remove dead code from BenchmarkGroupedTypedHistogram
1 parent 6a90e50 commit fb2b3e0

2 files changed

Lines changed: 1 addition & 17 deletions

File tree

core/trino-main/src/test/java/io/trino/operator/aggregation/BenchmarkGroupedTypedHistogram.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,6 @@ public static class Data
6565
// @Param({"1", "5", "50"})
6666
@Param("32") // size of entries--we have no idea here, could be 8 long (common in anecdotal) or longer strings
6767
private int rowSize;
68-
// these must be manually set in each class now; the mechanism to change and test was removed; the enum was kept in case we want to revisit. Retesting showed linear was superior
69-
// // @Param({"LINEAR", "SUM_OF_COUNT", "SUM_OF_SQUARE"})
70-
// @Param({"LINEAR"}) // found to be best, by about 10-15%
71-
// private ProbeType mainProbeTyepe;
72-
// // @Param({"LINEAR", "SUM_OF_COUNT", "SUM_OF_SQUARE"})
73-
// @Param({"LINEAR"}) // found to best
74-
// private ProbeType valueStoreProbeType;
7568

7669
private final Random random = new Random();
7770
private Page[] pages;
@@ -155,9 +148,4 @@ static void main()
155148
.withOptions(optionsBuilder -> optionsBuilder.addProfiler(GCProfiler.class))
156149
.run();
157150
}
158-
159-
public enum ProbeType
160-
{
161-
LINEAR, SUM_OF_COUNT, SUM_OF_SQUARE
162-
}
163151
}

core/trino-spi/src/test/java/io/trino/spi/block/BenchmarkCopyPositions.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,7 @@ public static class BenchmarkData
6565
@Param({"false", "true"})
6666
private boolean nullsAllowed;
6767

68-
@Param({
69-
"GROUPED",
70-
"SEQUENCE",
71-
"RANDOM",
72-
})
68+
@Param
7369
private SelectedPositions selectedPositions;
7470

7571
@Param({"VARCHAR", "ROW(BIGINT)"})

0 commit comments

Comments
 (0)