fixup! fixup! Add gcs.auth-type configuration

Author: chenjian2664

docs/src/main/sphinx/object-storage/file-system-gcs.md

@@ -74,7 +74,7 @@ Cloud Storage:
 * - `gcs.auth-type`
   - Authentication type to use for Google Cloud Storage access. Default to `DEFAULT`.
   Supported values are:
-    * `DEFAULT`: loads credentials from the environment. Either `gcs.json-key` or
+    * `SERVICE_ACCOUNT`: loads credentials from the environment. Either `gcs.json-key` or
       `gcs.json-key-file-path` can be set in addition to override the default
       credentials provider.
     * `ACCESS_TOKEN`: usage of client-provided OAuth 2.0 token to access Google

lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java

@@ -305,7 +305,7 @@ public boolean isAuthMethodValid()
     }
 
     @AssertFalse(message = "Cannot set both gcs.use-access-token and gcs.auth-type")
-    public boolean areAuthTypeAndGcsAccessTokenConfigured()
+    public boolean isAuthTypeAndGcsAccessTokenConfigured()
     {
         return authType.isPresent() && useGcsAccessToken.isPresent();
     }

lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestGcsFileSystemConfig.java

@@ -17,6 +17,7 @@
 import io.airlift.units.DataSize;
 import io.airlift.units.Duration;
 import io.trino.filesystem.gcs.GcsFileSystemConfig.AuthType;
+import jakarta.validation.constraints.AssertFalse;
 import jakarta.validation.constraints.AssertTrue;
 import org.junit.jupiter.api.Test;
 
@@ -169,32 +170,32 @@ public void testValidation()
                 new GcsFileSystemConfig()
                         .setAuthType(AuthType.ACCESS_TOKEN)
                         .setUseGcsAccessToken(true),
-                "authTypeAndUseGcsAccessTokenMutuallyExclusive",
+                "authTypeAndGcsAccessTokenConfigured",
                 "Cannot set both gcs.use-access-token and gcs.auth-type",
-                AssertTrue.class);
+                AssertFalse.class);
 
         assertFailsValidation(
                 new GcsFileSystemConfig()
                         .setAuthType(AuthType.ACCESS_TOKEN)
                         .setUseGcsAccessToken(false),
-                "authTypeAndUseGcsAccessTokenMutuallyExclusive",
+                "authTypeAndGcsAccessTokenConfigured",
                 "Cannot set both gcs.use-access-token and gcs.auth-type",
-                AssertTrue.class);
+                AssertFalse.class);
 
         assertFailsValidation(
                 new GcsFileSystemConfig()
                         .setUseGcsAccessToken(true)
                         .setAuthType(AuthType.SERVICE_ACCOUNT),
-                "authTypeAndUseGcsAccessTokenMutuallyExclusive",
+                "authTypeAndGcsAccessTokenConfigured",
                 "Cannot set both gcs.use-access-token and gcs.auth-type",
-                AssertTrue.class);
+                AssertFalse.class);
 
         assertFailsValidation(
                 new GcsFileSystemConfig()
                         .setUseGcsAccessToken(false)
                         .setAuthType(AuthType.SERVICE_ACCOUNT),
-                "authTypeAndUseGcsAccessTokenMutuallyExclusive",
+                "authTypeAndGcsAccessTokenConfigured",
                 "Cannot set both gcs.use-access-token and gcs.auth-type",
-                AssertTrue.class);
+                AssertFalse.class);
     }
 }