Skip to content

Commit 3b6d6a0

Browse files
committed
Reduce log verbosity in tests
Test runs emit several startup banners and one-shot diagnostics that are useful in production but pure noise in unit tests, where the same constructors and modules are exercised hundreds of times per run. Silence the noisiest sources for the affected tests and the testing server. Prefer WARN over ERROR so genuine problems still surface.
1 parent a88468f commit 3b6d6a0

4 files changed

Lines changed: 28 additions & 1 deletion

File tree

core/trino-main/src/main/java/io/trino/server/testing/TestingTrinoServer.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,12 @@ public class TestingTrinoServer
158158
{
159159
static {
160160
Logging logging = Logging.initialize();
161+
logging.setLevel("io.trino.connector.CatalogStoreManager", Level.WARN);
162+
logging.setLevel("io.trino.server.PluginManager", Level.WARN);
163+
logging.setLevel("io.trino.memory.RemoteNodeMemory", Level.ERROR);
161164
logging.setLevel("io.trino.event.QueryMonitor", Level.ERROR);
162165
logging.setLevel("org.eclipse.jetty", Level.ERROR);
166+
logging.setLevel("io.airlift.http.server", Level.WARN);
163167
logging.setLevel("io.airlift.concurrent.BoundedExecutor", Level.OFF);
164168

165169
// Trino server behavior does not depend on locale settings.

core/trino-main/src/main/java/io/trino/testing/PlanTester.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import io.airlift.json.JsonCodec;
2323
import io.airlift.json.JsonCodecFactory;
2424
import io.airlift.json.JsonMapperProvider;
25+
import io.airlift.log.Level;
26+
import io.airlift.log.Logging;
2527
import io.airlift.node.NodeInfo;
2628
import io.airlift.units.Duration;
2729
import io.opentelemetry.api.trace.Span;
@@ -287,6 +289,11 @@ public class PlanTester
287289
{
288290
public static final BlockEncodingManager TESTING_BLOCK_ENCODING_MANAGER = new BlockEncodingManager(new BlockEncodingSimdSupport(true));
289291

292+
static {
293+
Logging logging = Logging.initialize();
294+
logging.setLevel("org.hibernate.validator.internal.util.Version", Level.WARN);
295+
}
296+
290297
private final Session defaultSession;
291298
private final ExecutorService notificationExecutor;
292299
private final ScheduledExecutorService yieldExecutor;

core/trino-main/src/test/java/io/trino/execution/scheduler/faulttolerant/TestTaskDescriptorStorage.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
import io.airlift.jaxrs.JaxRsJsonMapper;
2525
import io.airlift.json.JsonCodec;
2626
import io.airlift.json.JsonModule;
27+
import io.airlift.log.Level;
28+
import io.airlift.log.Logging;
2729
import io.airlift.units.DataSize;
2830
import io.trino.connector.CatalogHandle;
2931
import io.trino.exchange.SpoolingExchangeInput;
@@ -53,6 +55,11 @@
5355

5456
public class TestTaskDescriptorStorage
5557
{
58+
static {
59+
Logging logging = Logging.initialize();
60+
logging.setLevel("org.hibernate.validator.internal.util.Version", Level.WARN);
61+
}
62+
5663
private static final QueryId QUERY_1 = new QueryId("query1");
5764
private static final QueryId QUERY_2 = new QueryId("query2");
5865

@@ -363,7 +370,9 @@ private static TaskDescriptorStorage createTaskDescriptorStorage(DataSize maxMem
363370
jsonCodecBinder(binder).bindJsonCodec(Split.class);
364371
});
365372

366-
Injector injector = app.initialize();
373+
Injector injector = app
374+
.doNotInitializeLogging()
375+
.initialize();
367376
JsonCodec<TaskDescriptor> taskDescriptorJsonCodec = injector.getInstance(Key.get(new TypeLiteral<>() {}));
368377

369378
TaskDescriptorStorage manager = new TaskDescriptorStorage(maxMemory, compressingHighWaterMark, compressingLowWaterMark, taskDescriptorJsonCodec);

core/trino-main/src/test/java/io/trino/server/protocol/spooling/TestPreferredQueryDataEncoderSelector.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
*/
1414
package io.trino.server.protocol.spooling;
1515

16+
import io.airlift.log.Level;
17+
import io.airlift.log.Logging;
1618
import io.trino.server.protocol.spooling.QueryDataEncoder.EncoderSelector;
1719
import io.trino.server.protocol.spooling.encoding.JsonQueryDataEncoder;
1820
import org.junit.jupiter.api.Test;
@@ -24,6 +26,11 @@
2426

2527
class TestPreferredQueryDataEncoderSelector
2628
{
29+
static {
30+
Logging logging = Logging.initialize();
31+
logging.setLevel("io.trino.server.protocol.spooling.QueryDataEncoders", Level.WARN);
32+
}
33+
2734
@Test
2835
public void testNoEncoderWhenNoneIsMatching()
2936
{

0 commit comments

Comments
 (0)