From 45b3b0ef1662508cda58eee191246afad67d9682 Mon Sep 17 00:00:00 2001 From: Anthony Spring Date: Thu, 23 Apr 2026 23:38:21 +0100 Subject: [PATCH 1/5] feat: Allow trino ServiceAccount to configure automountServiceAccountToken This change introduces 'serviceaccount.automount`, which defaults to false, to allow configuring the automountServiceAccountToken setting of the service account. --- charts/trino/templates/serviceaccount.yaml | 1 + charts/trino/values.yaml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/charts/trino/templates/serviceaccount.yaml b/charts/trino/templates/serviceaccount.yaml index a61c0724..5df63124 100644 --- a/charts/trino/templates/serviceaccount.yaml +++ b/charts/trino/templates/serviceaccount.yaml @@ -10,4 +10,5 @@ metadata: annotations: {{- toYaml . | nindent 4 }} {{- end }} +automountServiceAccountToken: {{ .Values.serviceAccount.automount }} {{- end }} diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml index bfeee0e4..18106f3e 100644 --- a/charts/trino/values.yaml +++ b/charts/trino/values.yaml @@ -578,6 +578,8 @@ auth: {} serviceAccount: # -- Specifies whether a service account should be created create: false + # -- Automatically mount a ServiceAccount's API credentials? + automount: true # -- The name of the service account to use. # If not set and create is true, a name is generated using the fullname template name: "" From 3e7aa5d29379ef8b887575399f6edc21967a72bc Mon Sep 17 00:00:00 2001 From: Anthony Spring Date: Thu, 23 Apr 2026 23:55:49 +0100 Subject: [PATCH 2/5] docs: generate docs with pre-commit --- charts/trino/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/charts/trino/README.md b/charts/trino/README.md index f64e8aa3..8be6b2fe 100644 --- a/charts/trino/README.md +++ b/charts/trino/README.md @@ -484,6 +484,9 @@ Fast distributed SQL query engine for big data analytics that helps you explore * `serviceAccount.create` - bool, default: `false` Specifies whether a service account should be created +* `serviceAccount.automount` - bool, default: `true` + + Automatically mount a ServiceAccount's API credentials? * `serviceAccount.name` - string, default: `""` The name of the service account to use. If not set and create is true, a name is generated using the fullname template From d5d71ba28daefe0b5e190292348cb786f21010f8 Mon Sep 17 00:00:00 2001 From: Anthony Spring Date: Tue, 28 Apr 2026 15:07:04 +0100 Subject: [PATCH 3/5] chore: Revise documentation based on suggestion --- charts/gateway/README.md | 2 +- charts/gateway/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/gateway/README.md b/charts/gateway/README.md index 6fe3c181..a891d4d8 100644 --- a/charts/gateway/README.md +++ b/charts/gateway/README.md @@ -195,7 +195,7 @@ A Helm chart for Trino Gateway Specifies whether a service account should be created * `serviceAccount.automount` - bool, default: `true` - Automatically mount a ServiceAccount's API credentials? + Automatically mount a ServiceAccount's API credentials * `serviceAccount.annotations` - object, default: `{}` Annotations to add to the service account diff --git a/charts/gateway/values.yaml b/charts/gateway/values.yaml index 33ecc6b0..2416b5ef 100644 --- a/charts/gateway/values.yaml +++ b/charts/gateway/values.yaml @@ -251,7 +251,7 @@ securityContext: {} serviceAccount: # -- Specifies whether a service account should be created create: true - # -- Automatically mount a ServiceAccount's API credentials? + # -- Automatically mount a ServiceAccount's API credentials automount: true # -- Annotations to add to the service account annotations: {} From 00c75876a66636806e7a80c6f22f2a08dcf931ee Mon Sep 17 00:00:00 2001 From: Anthony Spring Date: Tue, 28 Apr 2026 17:34:04 +0100 Subject: [PATCH 4/5] chore: Remove ? --- charts/trino/README.md | 2 +- charts/trino/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/trino/README.md b/charts/trino/README.md index 8be6b2fe..ffb0b6f4 100644 --- a/charts/trino/README.md +++ b/charts/trino/README.md @@ -486,7 +486,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore Specifies whether a service account should be created * `serviceAccount.automount` - bool, default: `true` - Automatically mount a ServiceAccount's API credentials? + Automatically mount a ServiceAccount's API credentials * `serviceAccount.name` - string, default: `""` The name of the service account to use. If not set and create is true, a name is generated using the fullname template diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml index 18106f3e..0c4cdb49 100644 --- a/charts/trino/values.yaml +++ b/charts/trino/values.yaml @@ -578,7 +578,7 @@ auth: {} serviceAccount: # -- Specifies whether a service account should be created create: false - # -- Automatically mount a ServiceAccount's API credentials? + # -- Automatically mount a ServiceAccount's API credentials automount: true # -- The name of the service account to use. # If not set and create is true, a name is generated using the fullname template From cfa64e7271343ff58459cb662e81b683608802a0 Mon Sep 17 00:00:00 2001 From: Anthony Spring Date: Thu, 23 Apr 2026 23:38:21 +0100 Subject: [PATCH 5/5] Introduce automountServiceAccountToken management This change introduces 'serviceaccount.automount`, which defaults to false, to allow configuring the automountServiceAccountToken setting of the service account. --- charts/gateway/README.md | 2 +- charts/gateway/values.yaml | 2 +- charts/trino/README.md | 3 +++ charts/trino/templates/serviceaccount.yaml | 1 + charts/trino/values.yaml | 2 ++ 5 files changed, 8 insertions(+), 2 deletions(-) diff --git a/charts/gateway/README.md b/charts/gateway/README.md index 6fe3c181..a891d4d8 100644 --- a/charts/gateway/README.md +++ b/charts/gateway/README.md @@ -195,7 +195,7 @@ A Helm chart for Trino Gateway Specifies whether a service account should be created * `serviceAccount.automount` - bool, default: `true` - Automatically mount a ServiceAccount's API credentials? + Automatically mount a ServiceAccount's API credentials * `serviceAccount.annotations` - object, default: `{}` Annotations to add to the service account diff --git a/charts/gateway/values.yaml b/charts/gateway/values.yaml index 33ecc6b0..2416b5ef 100644 --- a/charts/gateway/values.yaml +++ b/charts/gateway/values.yaml @@ -251,7 +251,7 @@ securityContext: {} serviceAccount: # -- Specifies whether a service account should be created create: true - # -- Automatically mount a ServiceAccount's API credentials? + # -- Automatically mount a ServiceAccount's API credentials automount: true # -- Annotations to add to the service account annotations: {} diff --git a/charts/trino/README.md b/charts/trino/README.md index f64e8aa3..ffb0b6f4 100644 --- a/charts/trino/README.md +++ b/charts/trino/README.md @@ -484,6 +484,9 @@ Fast distributed SQL query engine for big data analytics that helps you explore * `serviceAccount.create` - bool, default: `false` Specifies whether a service account should be created +* `serviceAccount.automount` - bool, default: `true` + + Automatically mount a ServiceAccount's API credentials * `serviceAccount.name` - string, default: `""` The name of the service account to use. If not set and create is true, a name is generated using the fullname template diff --git a/charts/trino/templates/serviceaccount.yaml b/charts/trino/templates/serviceaccount.yaml index a61c0724..5df63124 100644 --- a/charts/trino/templates/serviceaccount.yaml +++ b/charts/trino/templates/serviceaccount.yaml @@ -10,4 +10,5 @@ metadata: annotations: {{- toYaml . | nindent 4 }} {{- end }} +automountServiceAccountToken: {{ .Values.serviceAccount.automount }} {{- end }} diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml index bfeee0e4..0c4cdb49 100644 --- a/charts/trino/values.yaml +++ b/charts/trino/values.yaml @@ -578,6 +578,8 @@ auth: {} serviceAccount: # -- Specifies whether a service account should be created create: false + # -- Automatically mount a ServiceAccount's API credentials + automount: true # -- The name of the service account to use. # If not set and create is true, a name is generated using the fullname template name: ""