Need an option to disable ClickFailed screenshots, better logging

[bilts]

We ended up with over 14,000 ClickFailed screenshots in our CI /tmp directory, I assume due to some sort of synchronization loop (Capybara::Webkit::ClickFailed is returned by invalid_element_errors, indicating Capybara should retry it), though the test logs do not report an abnormal number of screenshots.

The new ClickFailed screenshot feature should be refined to address this in a couple of ways:

1. There should be a configuration option to disable the screenshot behavior entirely.
2. (Ideally) The driver should avoid taking screenshots repeatedly in sync loops.
3. (Alternatively) Every screenshot taken should be logged, regardless of whether its associated error is thrown, making this sort of problem easier to spot.

[jferris]

Saving screenshots during the retry loop was unintentional. I'll look into a way to reduce the number of screenshots we're saving here. I'll try to take care of number two. I'd be interested in a tested pull request that adds number one.

ps - your avatar is a baby, so I read your message in a baby voice in my head

[calleluks]

@jferris Did you look into reducing the number of screenshots saved? Can this issue be closed?

[jferris]

I haven't yet, no.

[jferris]

@mhoran any thoughts on this? I don't see a place in the driver API where we would make this change. It may make more sense to remove this auto-screenshot behavior and try to get something more generic into Capybara for saving screenshots for certain errors.

[mhoran]

I agree. Let's pull this out of capybara-webkit for now.

[jferris]

I opened #800 to resolve this issue.