From dadadb00cb1b52da56eb08a3f924d2a13bf2de68 Mon Sep 17 00:00:00 2001
From: Pablo Brasero <pablo@pablobm.com>
Date: Fri, 17 Jul 2026 10:52:36 +0100
Subject: [PATCH] Minimise exemptions to StandardRB rules

---
 spec/controllers/admin/orders_controller_spec.rb | 2 --
 spec/features/authorization_spec.rb              | 4 ++--
 spec/lib/administrate/search_spec.rb             | 4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/spec/controllers/admin/orders_controller_spec.rb b/spec/controllers/admin/orders_controller_spec.rb
index da11846659..51133bd66e 100644
--- a/spec/controllers/admin/orders_controller_spec.rb
+++ b/spec/controllers/admin/orders_controller_spec.rb
@@ -3,7 +3,6 @@
 # Test Authorization by using the Pundit concern and an example policy,
 # which will test all the authorization functionality.
 
-# standard:disable Lint/ConstantDefinitionInBlock
 describe Admin::OrdersController, type: :controller do
   context "with namespaced Punditize concern" do
     controller(Admin::OrdersController) do
@@ -107,4 +106,3 @@ def send_request(order:)
     end
   end
 end
-# standard:enable Lint/ConstantDefinitionInBlock
diff --git a/spec/features/authorization_spec.rb b/spec/features/authorization_spec.rb
index 81d531785d..3ee21afb35 100644
--- a/spec/features/authorization_spec.rb
+++ b/spec/features/authorization_spec.rb
@@ -1,8 +1,8 @@
 require "rails_helper"
 
-# standard:disable Lint/ConstantDefinitionInBlock
 describe "authorization" do
   before do
+    # standard:disable Lint/ConstantDefinitionInBlock
     class TestProductPolicy < ProductPolicy
       class Scope < ProductPolicy::Scope
         def resolve
@@ -14,6 +14,7 @@ def show?
         false
       end
     end
+    # standard:enable Lint/ConstantDefinitionInBlock
 
     @original_product_policy = Product.policy_class
     Product.policy_class = TestProductPolicy
@@ -55,4 +56,3 @@ def become_user(customer)
     expect(page).to have_css(".js-table-row", count: 1)
   end
 end
-# standard:enable Lint/ConstantDefinitionInBlock
diff --git a/spec/lib/administrate/search_spec.rb b/spec/lib/administrate/search_spec.rb
index 62ad3b5694..4fbae9c810 100644
--- a/spec/lib/administrate/search_spec.rb
+++ b/spec/lib/administrate/search_spec.rb
@@ -10,9 +10,9 @@
 require "administrate/base_dashboard"
 require "administrate/search"
 
-# standard:disable Lint/ConstantDefinitionInBlock
 describe Administrate::Search do
   before :all do
+    # standard:disable Lint/ConstantDefinitionInBlock
     module Administrate
       module SearchSpecMocks
         class MockRecord < ApplicationRecord
@@ -69,6 +69,7 @@ class FooDashboard < Administrate::BaseDashboard
         end
       end
     end
+    # standard:enable Lint/ConstantDefinitionInBlock
   end
 
   after :all do
@@ -225,4 +226,3 @@ class User < ApplicationRecord
     end
   end
 end
-# standard:enable Lint/ConstantDefinitionInBlock