You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(check-build): collapse foundry/forge checks and add changelog
Address review feedback on OffchainLabs#4677:
- rename forge_max_version -> forge_version_needed (compare_versions
uses exact match, not a ceiling)
- collapse Foundry/forge installation blocks into one cascade so the
user sees a single appropriate error
- print success message when forge version matches (previously the
matched branch printed the "not compatible" error)
- add changelog/tenderdeve-nit-4379.md
echo -e "${RED}forge version $FORGE_INSTALLED_VERSION is not compatible. Version $forge_max_version is required (newer versions use solar instead of solc for Yul compilation). Run: foundryup --version $forge_max_version${NC}"
206
+
echo -e "${GREEN}forge version $FORGE_INSTALLED_VERSION is installed.${NC}"
207
+
else
208
+
echo -e "${RED}forge version $FORGE_INSTALLED_VERSION is not compatible. Version $forge_version_needed is required (newer versions use solar instead of solc for Yul compilation). Run: foundryup --version $forge_version_needed${NC}"
209
209
EXIT_CODE=1
210
210
fi
211
-
else
212
-
echo -e "${RED}forge is not installed. Install Foundry and run: foundryup --version $forge_max_version${NC}"
0 commit comments