Increase shutdown cache TTL to 2 minutes (longer than long poll timeout)

rkannan82 · rkannan82 · commit 441d5b69365b · 2026-02-13T15:25:44.000-08:00
diff --git a/common/dynamicconfig/constants.go b/common/dynamicconfig/constants.go
@@ -477,10 +477,11 @@ Deleted Redirect Rules will be kept in the DB (with DeleteTimestamp). After this
 	)
 	ShutdownWorkerCacheTTL = NewGlobalDurationSetting(
 		"matching.ShutdownWorkerCacheTTL",
-		60*time.Second,
+		2*time.Minute,
 		`ShutdownWorkerCacheTTL is the time to live for entries in the shutdown worker cache. When a worker calls
 		ShutdownWorker, its WorkerInstanceKey is cached for this duration. Any poll arriving with a cached
-		WorkerInstanceKey returns empty immediately, preventing task dispatch to a shutting-down worker.`,
+		WorkerInstanceKey returns empty immediately, preventing task dispatch to a shutting-down worker.
+		This should be longer than MatchingLongPollExpirationInterval (default 1 min) to catch any in-flight polls.`,
 	)
 	ReachabilityBuildIdVisibilityGracePeriod = NewNamespaceDurationSetting(
 		"matching.wv.ReachabilityBuildIdVisibilityGracePeriod",

Original file line number	Diff line number	Diff line change
`@@ -477,10 +477,11 @@ Deleted Redirect Rules will be kept in the DB (with DeleteTimestamp). After this`
`477`	`477`	`)`
`478`	`478`	`ShutdownWorkerCacheTTL = NewGlobalDurationSetting(`
`479`	`479`	`"matching.ShutdownWorkerCacheTTL",`
`480`		`- 60*time.Second,`
	`480`	`+ 2*time.Minute,`
`481`	`481`	`ShutdownWorkerCacheTTL is the time to live for entries in the shutdown worker cache. When a worker calls
`482`	`482`	`ShutdownWorker, its WorkerInstanceKey is cached for this duration. Any poll arriving with a cached`
`483`		- WorkerInstanceKey returns empty immediately, preventing task dispatch to a shutting-down worker.`,
	`483`	`+ WorkerInstanceKey returns empty immediately, preventing task dispatch to a shutting-down worker.`
	`484`	+ This should be longer than MatchingLongPollExpirationInterval (default 1 min) to catch any in-flight polls.`,
`484`	`485`	`)`
`485`	`486`	`ReachabilityBuildIdVisibilityGracePeriod = NewNamespaceDurationSetting(`
`486`	`487`	`"matching.wv.ReachabilityBuildIdVisibilityGracePeriod",`